Replace bcopy() to update ether_addr

Warner Losh imp at bsdimp.com
Mon Aug 20 19:20:33 UTC 2012


On Aug 20, 2012, at 1:17 PM, Wojciech Puchar wrote:

>>> or use ++.
>>> 
>>> i think it is always aligned to 2 bytes and this should produce usable code on any CPU? should be 6 instructions on MIPS and PPC IMHO.
>> 
>> We should tag it as __aligned(2) then, no?  If so, then the compiler should generate the code you posted.
> should is the most important word in Your post. what it actually do - i don't know.

If we are requiring this to be __aligned(2), we should tag it as such to enforce this.

Even without this tagging, the code to do a structure level copy of 6 bytes is going to be tiny...

Warner



More information about the freebsd-hackers mailing list