[PATCH] avoid assuming MAXPATHLEN in config(8)

Ed Schouten ed at 80386.nl
Thu Jul 7 10:01:27 UTC 2011


Hi Robert,

* Robert Millan <rmh at debian.org>, 20110707 11:33:
> config(8) assumes MAXPATHLEN is defined in a few places, but presence
> of this macro isn't garanteed (POSIX says that it is only present when
> a file length limit exists, which may not be the case).

Even though it is good to make our code conform to standards as much as
possible, do keep in mind that your patch also causes a lot of
regressions in that area. The code now uses asprintf(), which is not
part of POSIX. I also think the use of __GLIBC__ is frowned upon.

-- 
 Ed Schouten <ed at 80386.nl>
 WWW: http://80386.nl/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20110707/32a09f3e/attachment.pgp


More information about the freebsd-hackers mailing list