[PATCH] Fix 'implicit declaration' warning and update vgone(9)

[Sergey Kandaurov]

On 27 October 2010 15:33, Sergey Kandaurov <pluknet at gmail.com> wrote:
> On 27 October 2010 10:23, Lars Hartmann <lars at chaotika.org> wrote:
>> The vgonel function isnt declarated in any header, the vgonel prototype
>> in vgone(9) isnt correct - found by Ben Kaduk <kaduk at mit.edu>
>
> Hi.
>
> I'm afraid it's just an overlooked man page after many VFS changes in 5.x.
> As vgonel() is a static (i.e. private and not visible from outside) function
> IMO it should be removed from vgone(9) man page.
>

Something like this I'd like to check in. Comments?

Index: ObsoleteFiles.inc
===================================================================
--- ObsoleteFiles.inc   (revision 214414)
+++ ObsoleteFiles.inc   (working copy)
@@ -14,6 +14,8 @@
 # The file is partitioned: OLD_FILES first, then OLD_LIBS and OLD_DIRS last.
 #

+# 20101027: vgonel(9) has gone to private API a while ago
+OLD_FILES+=usr/share/man/man9/vgonel.9.gz
 # 20101020: catch up with vm_page_sleep_if_busy rename
 OLD_FILES+=usr/share/man/man9/vm_page_sleep_busy.9.gz
 # 20101011: removed subblock.h from liblzma
Index: share/man/man9/Makefile
===================================================================
--- share/man/man9/Makefile     (revision 214413)
+++ share/man/man9/Makefile     (working copy)
@@ -1317,7 +1317,6 @@
        vfs_getopt.9 vfs_setopt_part.9 \
        vfs_getopt.9 vfs_setopts.9
 MLINKS+=VFS_LOCK_GIANT.9 VFS_UNLOCK_GIANT.9
-MLINKS+=vgone.9 vgonel.9
 MLINKS+=vhold.9 vdrop.9 \
        vhold.9 vdropl.9 \
        vhold.9 vholdl.9
Index: share/man/man9/vgone.9
===================================================================
--- share/man/man9/vgone.9      (revision 214413)
+++ share/man/man9/vgone.9      (working copy)
@@ -26,24 +26,21 @@
 .\"
 .\" $FreeBSD$
 .\"
-.Dd November 21, 2001
+.Dd October 27, 2010
 .Dt VGONE 9
 .Os
 .Sh NAME
-.Nm vgone , vgonel
+.Nm vgone
 .Nd "prepare a vnode for reuse"
 .Sh SYNOPSIS
 .In sys/param.h
 .In sys/vnode.h
 .Ft void
 .Fn vgone "struct vnode *vp"
-.Ft void
-.Fn vgonel "struct vnode *vp" "struct thread *td"
 .Sh DESCRIPTION
+The
 .Fn vgone
-and
-.Fn vgonel
-prepare a vnode for reuse by another file system.
+function prepares a vnode for reuse by another file system.
 The preparation includes the cleaning of all file system specific data and
 the removal from its mount point vnode list.
 .Pp
@@ -55,17 +52,11 @@
 as in most cases the vnode
 is about to be reused, or its file system is being unmounted.
 .Pp
-The difference between
+The
 .Fn vgone
-and
-.Fn vgonel
-is that
-.Fn vgone
-locks the vnode interlock and then calls
-.Fn vgonel
-while
-.Fn vgonel
-expects the interlock to already be locked.
+function takes an unlocked vnode and returns with the vnode unlocked.
+.Sh SEE ALSO
+.Xr vnode 9
 .Sh AUTHORS
 This manual page was written by
 .An Chad David Aq davidc at acns.ab.ca .
Index: share/man/man9/vflush.9
===================================================================
--- share/man/man9/vflush.9     (revision 214413)
+++ share/man/man9/vflush.9     (working copy)
@@ -75,7 +75,6 @@
 will be returned.
 .Sh SEE ALSO
 .Xr vgone 9 ,
-.Xr vgonel 9 ,
 .Xr vrele 9
 .Sh AUTHORS
 This manual page was written by


-- 
wbr,
pluknet