SCSI_DELAY cleanup

Alexander Best arundel at freebsd.org
Mon Oct 18 23:53:18 UTC 2010


any thoughts on this patch?

i noticed the "default" SCSI_DELAY value of 2000ms was only used in very few
places so i thought it would make more sense making 5000ms the default and
adding a few special cases where SCSI_DELAY can in fact be lowered down to
2000ms.

cheers.
alex

-- 
a13x
-------------- next part --------------
diff --git a/sys/amd64/conf/GENERIC b/sys/amd64/conf/GENERIC
index 3bc6299..df26ea6 100644
--- a/sys/amd64/conf/GENERIC
+++ b/sys/amd64/conf/GENERIC
@@ -49,7 +49,6 @@ options 	COMPAT_FREEBSD4		# Compatible with FreeBSD4
 options 	COMPAT_FREEBSD5		# Compatible with FreeBSD5
 options 	COMPAT_FREEBSD6		# Compatible with FreeBSD6
 options 	COMPAT_FREEBSD7		# Compatible with FreeBSD7
-options 	SCSI_DELAY=5000		# Delay (in ms) before probing SCSI
 options 	KTRACE			# ktrace(1) support
 options 	STACK			# stack(9) support
 options 	SYSVSHM			# SYSV-style shared memory
diff --git a/sys/amd64/conf/XENHVM b/sys/amd64/conf/XENHVM
index 51f1256..47cdc83 100644
--- a/sys/amd64/conf/XENHVM
+++ b/sys/amd64/conf/XENHVM
@@ -50,7 +50,6 @@ options 	COMPAT_FREEBSD4		# Compatible with FreeBSD4
 options 	COMPAT_FREEBSD5		# Compatible with FreeBSD5
 options 	COMPAT_FREEBSD6		# Compatible with FreeBSD6
 options 	COMPAT_FREEBSD7		# Compatible with FreeBSD7
-options 	SCSI_DELAY=5000		# Delay (in ms) before probing SCSI
 options 	KTRACE			# ktrace(1) support
 options 	STACK			# stack(9) support
 options 	SYSVSHM			# SYSV-style shared memory
diff --git a/sys/arm/conf/BWCT b/sys/arm/conf/BWCT
index 0fb3b87..34db9a7 100644
--- a/sys/arm/conf/BWCT
+++ b/sys/arm/conf/BWCT
@@ -57,7 +57,7 @@ options 	BOOTP
 #options 	CD9660			#ISO 9660 Filesystem
 #options 	PROCFS			#Process filesystem (requires PSEUDOFS)
 options 	PSEUDOFS		#Pseudo-filesystem framework
-#options 	SCSI_DELAY=5000		#Delay (in ms) before probing SCSI
+options 	SCSI_DELAY=2000		#Delay (in ms) before probing SCSI
 #options 	KTRACE			#ktrace(1) support
 options 	SYSVSHM			#SYSV-style shared memory
 options 	SYSVMSG			#SYSV-style message queues
diff --git a/sys/arm/conf/CNS11XXNAS b/sys/arm/conf/CNS11XXNAS
index 76db42b..b14b1b2 100644
--- a/sys/arm/conf/CNS11XXNAS
+++ b/sys/arm/conf/CNS11XXNAS
@@ -74,7 +74,6 @@ options 	MSDOSFS			#MSDOS Filesystem
 #options 	CD9660			#ISO 9660 Filesystem
 #options 	PROCFS			#Process filesystem (requires PSEUDOFS)
 options 	PSEUDOFS		#Pseudo-filesystem framework
-options 	SCSI_DELAY=5000		#Delay (in ms) before probing SCSI
 options 	KTRACE			#ktrace(1) support
 options 	SYSVSHM			#SYSV-style shared memory
 options 	SYSVMSG			#SYSV-style message queues
diff --git a/sys/arm/conf/CRB b/sys/arm/conf/CRB
index 2afd080..ff7fc1d 100644
--- a/sys/arm/conf/CRB
+++ b/sys/arm/conf/CRB
@@ -49,7 +49,6 @@ options 	NFS_ROOT		#NFS usable as /, requires NFSCLIENT
 options 	CD9660			#ISO 9660 Filesystem
 #options 	PROCFS			#Process filesystem (requires PSEUDOFS)
 options 	PSEUDOFS		#Pseudo-filesystem framework
-options 	SCSI_DELAY=5000		#Delay (in ms) before probing SCSI
 options 	KTRACE			#ktrace(1) support
 options 	INTR_FILTER
 options 	SYSVSHM			#SYSV-style shared memory
diff --git a/sys/arm/conf/EP80219 b/sys/arm/conf/EP80219
index 3c2c1aa..24cf837 100644
--- a/sys/arm/conf/EP80219
+++ b/sys/arm/conf/EP80219
@@ -48,7 +48,6 @@ options 	NFS_ROOT		#NFS usable as /, requires NFSCLIENT
 options 	CD9660			#ISO 9660 Filesystem
 #options 	PROCFS			#Process filesystem (requires PSEUDOFS)
 options 	PSEUDOFS		#Pseudo-filesystem framework
-options 	SCSI_DELAY=5000		#Delay (in ms) before probing SCSI
 options 	KTRACE			#ktrace(1) support
 options 	SYSVSHM			#SYSV-style shared memory
 options 	SYSVMSG			#SYSV-style message queues
diff --git a/sys/arm/conf/GUMSTIX b/sys/arm/conf/GUMSTIX
index e7900f5..973f6e3 100644
--- a/sys/arm/conf/GUMSTIX
+++ b/sys/arm/conf/GUMSTIX
@@ -53,7 +53,6 @@ options 	NFS_ROOT		#NFS usable as /, requires NFSCLIENT
 #options 	PROCFS			#Process filesystem (requires PSEUDOFS)
 options 	PSEUDOFS		#Pseudo-filesystem framework
 options 	COMPAT_43		#Compatible with BSD 4.3 [KEEP THIS!]
-options 	SCSI_DELAY=5000		#Delay (in ms) before probing SCSI
 options 	KTRACE			#ktrace(1) support
 options 	SYSVSHM			#SYSV-style shared memory
 options 	SYSVMSG			#SYSV-style message queues
diff --git a/sys/arm/conf/HL200 b/sys/arm/conf/HL200
index dd46a61..d7b6ab9 100644
--- a/sys/arm/conf/HL200
+++ b/sys/arm/conf/HL200
@@ -53,7 +53,7 @@ options 	BOOTP_COMPAT
 #options 	CD9660			#ISO 9660 Filesystem
 #options 	PROCFS			#Process filesystem (requires PSEUDOFS)
 options 	PSEUDOFS		#Pseudo-filesystem framework
-#options 	SCSI_DELAY=5000		#Delay (in ms) before probing SCSI
+options 	SCSI_DELAY=2000		#Delay (in ms) before probing SCSI
 #options 	KTRACE			#ktrace(1) support
 options 	SYSVSHM			#SYSV-style shared memory
 options 	SYSVMSG			#SYSV-style message queues
diff --git a/sys/arm/conf/HL201 b/sys/arm/conf/HL201
index 6524cc6..ad3606f 100644
--- a/sys/arm/conf/HL201
+++ b/sys/arm/conf/HL201
@@ -55,7 +55,7 @@ options		ALT_BREAK_TO_DEBUGGER
 #options 	CD9660			#ISO 9660 Filesystem
 #options 	PROCFS			#Process filesystem (requires PSEUDOFS)
 options 	PSEUDOFS		#Pseudo-filesystem framework
-#options 	SCSI_DELAY=5000		#Delay (in ms) before probing SCSI
+options 	SCSI_DELAY=2000		#Delay (in ms) before probing SCSI
 #options 	KTRACE			#ktrace(1) support
 options 	SYSVSHM			#SYSV-style shared memory
 options 	SYSVMSG			#SYSV-style message queues
diff --git a/sys/arm/conf/IQ31244 b/sys/arm/conf/IQ31244
index 8b79497..a2e4687 100644
--- a/sys/arm/conf/IQ31244
+++ b/sys/arm/conf/IQ31244
@@ -49,7 +49,6 @@ options 	NFS_ROOT		#NFS usable as /, requires NFSCLIENT
 options 	CD9660			#ISO 9660 Filesystem
 #options 	PROCFS			#Process filesystem (requires PSEUDOFS)
 options 	PSEUDOFS		#Pseudo-filesystem framework
-options 	SCSI_DELAY=5000		#Delay (in ms) before probing SCSI
 options 	KTRACE			#ktrace(1) support
 options 	SYSVSHM			#SYSV-style shared memory
 options 	SYSVMSG			#SYSV-style message queues
diff --git a/sys/arm/conf/KB920X b/sys/arm/conf/KB920X
index f47e9ac..3454d02 100644
--- a/sys/arm/conf/KB920X
+++ b/sys/arm/conf/KB920X
@@ -51,7 +51,7 @@ options 	NFSCLIENT		#Network Filesystem Client
 #options 	CD9660			#ISO 9660 Filesystem
 #options 	PROCFS			#Process filesystem (requires PSEUDOFS)
 options 	PSEUDOFS		#Pseudo-filesystem framework
-#options 	SCSI_DELAY=5000		#Delay (in ms) before probing SCSI
+options 	SCSI_DELAY=2000		#Delay (in ms) before probing SCSI
 #options 	KTRACE			#ktrace(1) support
 options 	SYSVSHM			#SYSV-style shared memory
 options 	SYSVMSG			#SYSV-style message queues
diff --git a/sys/arm/conf/LN2410SBC b/sys/arm/conf/LN2410SBC
index e4f3a54..bac3de8 100644
--- a/sys/arm/conf/LN2410SBC
+++ b/sys/arm/conf/LN2410SBC
@@ -49,7 +49,7 @@ options		ROOTDEVNAME=\"ufs:da0s1\"
 #options 	NFS_ROOT		#NFS usable as root device
 
 options 	PSEUDOFS		#Pseudo-filesystem framework
-#options 	SCSI_DELAY=5000		#Delay (in ms) before probing SCSI
+options 	SCSI_DELAY=2000		#Delay (in ms) before probing SCSI
 options 	KTRACE			#ktrace(1) support
 options 	SYSVSHM			#SYSV-style shared memory
 options 	SYSVMSG			#SYSV-style message queues
diff --git a/sys/arm/conf/NSLU b/sys/arm/conf/NSLU
index d921e34..1585689 100644
--- a/sys/arm/conf/NSLU
+++ b/sys/arm/conf/NSLU
@@ -66,7 +66,6 @@ options 	NFS_ROOT		#NFS usable as /, requires NFSCLIENT
 options 	CD9660			#ISO 9660 Filesystem
 #options 	PROCFS			#Process filesystem (requires PSEUDOFS)
 options 	PSEUDOFS		#Pseudo-filesystem framework
-options 	SCSI_DELAY=5000		#Delay (in ms) before probing SCSI
 options 	KTRACE			#ktrace(1) support
 options 	SYSVSHM			#SYSV-style shared memory
 options 	SYSVMSG			#SYSV-style message queues
diff --git a/sys/arm/conf/QILA9G20 b/sys/arm/conf/QILA9G20
index 55839ce..c1612df 100644
--- a/sys/arm/conf/QILA9G20
+++ b/sys/arm/conf/QILA9G20
@@ -57,7 +57,7 @@ options		ALT_BREAK_TO_DEBUGGER
 #options 	CD9660			#ISO 9660 Filesystem
 #options 	PROCFS			#Process filesystem (requires PSEUDOFS)
 #options 	PSEUDOFS		#Pseudo-filesystem framework
-#options 	SCSI_DELAY=5000		#Delay (in ms) before probing SCSI
+options 	SCSI_DELAY=2000		#Delay (in ms) before probing SCSI
 #options 	KTRACE			#ktrace(1) support
 options 	SYSVSHM			#SYSV-style shared memory
 options 	SYSVMSG			#SYSV-style message queues
diff --git a/sys/arm/conf/SAM9G20EK b/sys/arm/conf/SAM9G20EK
index 6c2e94e..368b615 100644
--- a/sys/arm/conf/SAM9G20EK
+++ b/sys/arm/conf/SAM9G20EK
@@ -56,7 +56,7 @@ options		ALT_BREAK_TO_DEBUGGER
 #options 	CD9660			#ISO 9660 Filesystem
 #options 	PROCFS			#Process filesystem (requires PSEUDOFS)
 #options 	PSEUDOFS		#Pseudo-filesystem framework
-#options 	SCSI_DELAY=5000		#Delay (in ms) before probing SCSI
+options 	SCSI_DELAY=2000		#Delay (in ms) before probing SCSI
 #options 	KTRACE			#ktrace(1) support
 options 	SYSVSHM			#SYSV-style shared memory
 options 	SYSVMSG			#SYSV-style message queues
diff --git a/sys/arm/conf/SKYEYE b/sys/arm/conf/SKYEYE
index b3aad2a..e7c843e 100644
--- a/sys/arm/conf/SKYEYE
+++ b/sys/arm/conf/SKYEYE
@@ -50,7 +50,6 @@ options 	NFS_ROOT		#NFS usable as /, requires NFSCLIENT
 options 	CD9660			#ISO 9660 Filesystem
 #options 	PROCFS			#Process filesystem (requires PSEUDOFS)
 options 	PSEUDOFS		#Pseudo-filesystem framework
-options 	SCSI_DELAY=5000		#Delay (in ms) before probing SCSI
 #options 	KTRACE			#ktrace(1) support
 options 	SYSVSHM			#SYSV-style shared memory
 options 	SYSVMSG			#SYSV-style message queues
diff --git a/sys/cam/scsi/scsi_all.c b/sys/cam/scsi/scsi_all.c
index cddac5c..7876393 100644
--- a/sys/cam/scsi/scsi_all.c
+++ b/sys/cam/scsi/scsi_all.c
@@ -70,7 +70,7 @@ __FBSDID("$FreeBSD$");
  * after a SCSI bus reset.
  */
 #ifndef SCSI_DELAY
-#define SCSI_DELAY 2000
+#define SCSI_DELAY 5000
 #endif
diff --git a/sys/i386/conf/GENERIC b/sys/i386/conf/GENERIC
index 85f4697..e1c0673 100644
--- a/sys/i386/conf/GENERIC
+++ b/sys/i386/conf/GENERIC
@@ -50,7 +50,6 @@ options 	COMPAT_FREEBSD4		# Compatible with FreeBSD4
 options 	COMPAT_FREEBSD5		# Compatible with FreeBSD5
 options 	COMPAT_FREEBSD6		# Compatible with FreeBSD6
 options 	COMPAT_FREEBSD7		# Compatible with FreeBSD7
-options 	SCSI_DELAY=5000		# Delay (in ms) before probing SCSI
 options 	KTRACE			# ktrace(1) support
 options 	STACK			# stack(9) support
 options 	SYSVSHM			# SYSV-style shared memory
diff --git a/sys/ia64/conf/GENERIC b/sys/ia64/conf/GENERIC
index 71af42c..ff43121 100644
--- a/sys/ia64/conf/GENERIC
+++ b/sys/ia64/conf/GENERIC
@@ -54,7 +54,6 @@ options 	PRINTF_BUFR_SIZE=128  # Printf buffering to limit interspersion
 options 	PROCFS		# Process filesystem (/proc)
 options 	PSEUDOFS	# Pseudo-filesystem framework
 options 	SCHED_ULE	# ULE scheduler
-options 	SCSI_DELAY=5000	# Delay (in ms) before probing SCSI
 options 	SCTP		# Stream Control Transmission Protocol
 options 	SMP		# Symmetric Multi-Processor support
 options 	SOFTUPDATES	# Enable FFS soft updates support
diff --git a/sys/mips/conf/OCTEON1 b/sys/mips/conf/OCTEON1
index a00e95d..db56e7c 100644
--- a/sys/mips/conf/OCTEON1
+++ b/sys/mips/conf/OCTEON1
@@ -65,7 +65,6 @@ options 	PSEUDOFS		# Pseudo-filesystem framework
 options 	GEOM_PART_GPT		# GUID Partition Tables.
 options 	GEOM_LABEL		# Provides labelization
 #options 	COMPAT_FREEBSD32	# Compatible with o32 binaries (not yet)
-options 	SCSI_DELAY=5000		# Delay (in ms) before probing SCSI
 options 	KTRACE			# ktrace(1) support
 options 	STACK			# stack(9) support
 options 	SYSVSHM			# SYSV-style shared memory
diff --git a/sys/pc98/conf/GENERIC b/sys/pc98/conf/GENERIC
index e137297..df937c6 100644
--- a/sys/pc98/conf/GENERIC
+++ b/sys/pc98/conf/GENERIC
@@ -50,7 +50,6 @@ options 	COMPAT_FREEBSD4		# Compatible with FreeBSD4
 options 	COMPAT_FREEBSD5		# Compatible with FreeBSD5
 options 	COMPAT_FREEBSD6		# Compatible with FreeBSD6
 options 	COMPAT_FREEBSD7		# Compatible with FreeBSD7
-options 	SCSI_DELAY=5000		# Delay (in ms) before probing SCSI
 options 	EPSON_BOUNCEDMA		# use bounce buffer for 15-16M
 #options 	EPSON_MEMWIN		# EPSON memory window support
 #options 	LINE30
diff --git a/sys/powerpc/conf/GENERIC b/sys/powerpc/conf/GENERIC
index c23e9ac..5f44ee8 100644
--- a/sys/powerpc/conf/GENERIC
+++ b/sys/powerpc/conf/GENERIC
@@ -54,7 +54,6 @@ options 	COMPAT_FREEBSD4		#Keep this for a while
 options 	COMPAT_FREEBSD5		#Compatible with FreeBSD5
 options 	COMPAT_FREEBSD6		#Compatible with FreeBSD6
 options 	COMPAT_FREEBSD7		#Compatible with FreeBSD7
-options 	SCSI_DELAY=5000		#Delay (in ms) before probing SCSI 
 options 	KTRACE			#ktrace(1) syscall trace support
 options 	STACK			#stack(9) support
 options 	SYSVSHM			#SYSV-style shared memory
diff --git a/sys/powerpc/conf/GENERIC64 b/sys/powerpc/conf/GENERIC64
index b861e51..9127c01 100644
--- a/sys/powerpc/conf/GENERIC64
+++ b/sys/powerpc/conf/GENERIC64
@@ -53,7 +53,6 @@ options 	COMPAT_FREEBSD32	#Compatible with FreeBSD/powerpc binaries
 options 	COMPAT_FREEBSD5		#Compatible with FreeBSD5
 options 	COMPAT_FREEBSD6		#Compatible with FreeBSD6
 options 	COMPAT_FREEBSD7		#Compatible with FreeBSD7
-options 	SCSI_DELAY=5000		#Delay (in ms) before probing SCSI 
 options 	KTRACE			#ktrace(1) syscall trace support
 options 	STACK			#stack(9) support
 options 	SYSVSHM			#SYSV-style shared memory
diff --git a/sys/sparc64/conf/GENERIC b/sys/sparc64/conf/GENERIC
index 6bbd4e1..60226d0 100644
--- a/sys/sparc64/conf/GENERIC
+++ b/sys/sparc64/conf/GENERIC
@@ -50,7 +50,6 @@ options 	GEOM_LABEL		# Provides labelization
 options 	COMPAT_FREEBSD5		# Compatible with FreeBSD5
 options 	COMPAT_FREEBSD6		# Compatible with FreeBSD6
 options 	COMPAT_FREEBSD7		# Compatible with FreeBSD7
-options 	SCSI_DELAY=5000		# Delay (in ms) before probing SCSI
 options 	KTRACE			# ktrace(1) support
 options 	STACK			# stack(9) support
 options 	SYSVSHM			# SYSV-style shared memory
diff --git a/sys/sun4v/conf/GENERIC b/sys/sun4v/conf/GENERIC
index 74fc036..0508048 100644
--- a/sys/sun4v/conf/GENERIC
+++ b/sys/sun4v/conf/GENERIC
@@ -51,7 +51,6 @@ options 	PROCFS			# Process filesystem (requires PSEUDOFS)
 options 	PSEUDOFS		# Pseudo-filesystem framework
 options 	GEOM_PART_GPT		# GUID Partition Tables.
 options 	GEOM_LABEL		# Provides labelization
-options 	SCSI_DELAY=5000		# Delay (in ms) before probing SCSI
 options 	KTRACE			# ktrace(1) support
 options 	STACK			# stack(9) support
 options 	SYSVSHM			# SYSV-style shared memory
diff --git a/share/man/man4/scsi.4 b/share/man/man4/scsi.4
index ad52663..d95b978 100644
--- a/share/man/man4/scsi.4
+++ b/share/man/man4/scsi.4
@@ -24,7 +24,7 @@
 .\" SUCH DAMAGE.
 .\"
 .\" $FreeBSD$
-.Dd March 4, 2010
+.Dd October 19, 2010
 .Dt CAM 4
 .Os
 .Sh NAME
@@ -47,7 +47,7 @@
 .Cd "options CAM_MAX_HIGHPOWER=4"
 .Cd "options SCSI_NO_SENSE_STRINGS"
 .Cd "options SCSI_NO_OP_STRINGS"
-.Cd "options SCSI_DELAY=8000"
+.Cd "options SCSI_DELAY=5000"
 .Sh DESCRIPTION
 The
 .Nm
@@ -116,7 +116,7 @@ Enabling this option for normal use is not recommended, since it slows
 debugging of
 .Tn SCSI
 problems.
-.It Dv SCSI_DELAY=8000
+.It Dv SCSI_DELAY=5000
 This is the
 .Tn SCSI
 "bus settle delay."
@@ -138,7 +138,7 @@ Newer disks
 may need as little as 100ms, while old, slow devices may need much longer.
 If the
 .Dv SCSI_DELAY
-is not specified, it defaults to 2 seconds.
+is not specified, it defaults to 5 seconds.
 The minimum allowable value for
 .Dv SCSI_DELAY
 is "100", or 100ms.


More information about the freebsd-hackers mailing list