tiny lib/libkvm/kvm_proc.c correction

Alexander Best alexbestms at wwu.de
Fri Mar 5 19:59:13 UTC 2010


Xin LI schrieb am 2010-03-05:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1

> On 2010/03/05 11:26, Alexander Best wrote:
> > hi there. does this look right?

> Not to me, the value is not to be used this way and the comments
> above
> the code explained the same thing.

> I think we should use cputick2usec but it's not available to userland
> (one have to copy cpu_tick_frequency and friends).

damn you're right. i completely overlooked that comment. would it be worth
making cputick2usec available to userland? is kvm_proc.c the only candidate in
need of converting cpu ticks to usecs?

alex

> Cheers,
> - --
> Xin LI <delphij at delphij.net>    http://www.delphij.net/
> FreeBSD - The Power to Serve!          Live free or die
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2.0.14 (FreeBSD)

> iQEcBAEBAgAGBQJLkV1EAAoJEATO+BI/yjfBvhcH/3LD5SOscV7wmzVazQtvhOpd
> C4xhRlnlZEniI8qrKP1L55Q9eTntxzcWZPhmImb5UspSX6a5aRsWHrySlD82Vjgy
> u/n/tz/YbhGV4QasmRxrXOF8wrPh3ie0W6912hFHmMZ6shgfm9GvoAlltnCcnnNp
> O330syWOVqf/q+9y5FOXIschYPs8HmAP7Fy5pMragpzdmpg5uCBdKXbekvfqiscN
> qPOOrzzyvkmXS3rKBY5vnRHqJTaOveSuE6KEjN1x/D0ZJ71kY6tLwZCCMc9wNlJB
> Dv/U3ZPo4lUki2tZTOi9bo4KEkLR/3zrFQ5VeaDhYI/FHCQTFB1jhNoahU2WlB0=
> =JOn5
> -----END PGP SIGNATURE-----


More information about the freebsd-hackers mailing list