`make cleanworld` and /usr/obj/lib32/usr/src

[Garrett Cooper]

On Mon, Mar 1, 2010 at 5:19 PM, Alexander Best <alexbestms at wwu.de> wrote:
> jhell schrieb am 2010-03-02:
>
>> On Mon, 1 Mar 2010 19:45, alexbestms@ wrote:
>> >jhell schrieb am 2010-03-02:
>
>> >>On Mon, 1 Mar 2010 14:52, alexbestms@ wrote:
>
>> >>>oh. and btw: wouldn't it be reasonable to prevent a user shooting
>> >>>himself in
>> >>>the foot if he has the brilliant idea of setting "MAKEOBJDIRPREFIX
>> >>>= /" ?
>
>> >>>alex
>
>
>> >>Trying to match something like this is going to get out of control.
>> >>Though this is a nice idea but why should a user be prevented from
>> >>doing such things ?.
>
>> >>Boiling down these are not variables that usually have to be
>> >>changed
>> >>and if they are changed the user has done a little bit of research
>> >>and is more advanced than most and recognizes that / is not a
>> >>option.
>
>> >hmmm...so you think something like this won't be useful?
>
>> >alex
>
>> >>--
>
>> >>jhell
>
>
>> What about the case where MAKEOBJDIRPREFIX="/ usr/obj/dir". I
>> suppose make will fail in this case but I don't have anything to
>> test this situation in ATM.
>
> nope. just tested it. only a real MAKEOBJDIRPREFIX="/" triggers the error.
>
>> But aside from that "typical user" never adjusts such things and it
>> adds just a slight bit more overhead to the build that can be
>> avoided altoghter by the user reading what they type.
>
> you're probably right. regular users will most definitely never come across
> MAKEOBJDIRPREFIX and if some advanced user decides to set it to "/" that's up
> to him.

What about these?

/./
/.
////
//

I avoided these errors by writing `abspath' for LTP (it was required
for GNU make backwards compatibility).

jhell is right though ... if you're going to go down this road it's
going to be a maintenance mess unless you have something that will
abspath the file (and I used 24 or so confusing lines in awk to do
it):

http://ltp.git.sourceforge.net/git/gitweb.cgi?p=ltp/ltp-dev.git;a=blob;f=scripts/lib/file_functions.sh;h=fd56492569e9bcfe19dd5d35db922cd94df77fb6;hb=HEAD

Thanks,
-Garrett