Comments on pmake diffs for building on Linux

Giorgos Keramidas keramida at ceid.upatras.gr
Tue Mar 4 16:00:55 UTC 2008


On 2008-03-04 08:52, "M. Warner Losh" <imp at bsdimp.com> wrote:
> In message: <20080304154542.GC61036 at kobe.laptop>
>             Giorgos Keramidas <keramida at ceid.upatras.gr> writes:
> : Nice!  Thank you Robert.  Can I copy parts of this and add them to the
> : autoconf glue I'm adding now?
> :
> : To test just cpp(1) stuff, autoconf supports AC_PREPROC_IFELSE() too,
> : which I used when I tried writing a check for __FBSDID():
> :
> :   AC_PREPROC_IFELSE(
> :     [AC_LANG_PROGRAM([[#include <sys/cdefs.h>
> :   #ifndef __FBSDID
> :   #error No __FBSDID definition.
> :   #endif]])],
> :     [AC_DEFINE([HAVE_FBSDID_MACRO], [1],
> :        [Define to 1 if you have the __FBSDID macro.])])
> :
> : I can probably improve a bit the queue.h check using what you wrote
> : above and AC_PREPROC_IFELSE().
>
> The alternative to uglifying the make sources with #ifdefs would be to
> just always use the compat includes when building...  No autoconf
> needed, and minimal changes to the base make, if any.

True.  I'll try to keep #ifdef changes down to the absolutely _minimum_
amount of changes.  It will make repeated merged from usr.bin/make much
easier, for example :)



More information about the freebsd-hackers mailing list