[PATCH] Fancy rc startup style RFC

Gordon Bergling gbergling at 0xfce3.net
Tue Apr 18 18:59:49 UTC 2006


* Thus spake Eric Anderson (anderson at centtech.com):
> Coleman Kane wrote:
> >On 4/18/06, *M. Warner Losh* <imp at bsdimp.com <mailto:imp at bsdimp.com>> 
> >wrote:
> >
> >    In message: <44452532.40703 at centtech.com
> >    <mailto:44452532.40703 at centtech.com>>
> >                Eric Anderson <anderson at centtech.com
> >    <mailto:anderson at centtech.com>> writes:
> >    : Gordon Bergling wrote:
> >    : > Hi,
> >    : >
> >    : > * Thus spake Eric Anderson (anderson at centtech.com
> >    <mailto:anderson at centtech.com>):
> >    : >> I've made a patch to /etc/rc.subr that makes the
> >    startup/shutdown rc
> >    : >> scripting look similar to other OS's (many different linux
> >    distros,
> >    : >> HP-UX, etc), but without color.
> >    : >>
> >    : >> The patch shouldn't break anything, and is only enabled if you
> >    have this
> >    : >> in your /etc/rc.conf:
> >    : >>
> >    : >> rc_fancy="YES"
> >    : >>
> >    : >> Several of the /etc/rc.d/* scripts send output to stdout, so
> >    that could
> >    : >> be cleaned up a bit if needed, but for now I tried to keep the
> >    patch as
> >    : >> minimal as possible.
> >    : >>
> >    : >> This is still a first pass, so please give feedback.
> >    : >
> >    : > A short try on my notebook shows some errors.
> >    : > I don't want to let this email getting too big, so I put the
> >    "dmesg -a"
> >    : > output online. http://generic.0xfce3.net/dmesg-fancy.txt
> >    : >
> >    : > BTW, the patch applied cleanly.
> >    :
> >    :
> >    : Thanks for the feedback!  Looks like I made an erroneous
> >    assumption that
> >    : the wc, expr, and printf tools found in /usr/bin and /bin would be
> >    : available through boot, but that isn't the case on systems with those
> >    : file systems separate from /.  I'm not sure how to resolve some of
> >    these
> >    : issues, since I don't know of a way to do those functions in csh
> >    without
> >    : them.  I'm open to suggestions here from anyone.
> >
> >    /bin and /sbin are available through the entire boot.  Only things in
> >    /usr are suspect because /usr gets mounted early in the boot process,
> >    but not as early as /.
> >
> >    Warner
> >
> >
> >Nice work!
> >
> >I too noticed the dependence upon wc, printf, expr. I went ahead and 
> >rewrote these into equivalents in native sh. (attaching new diff).
> >
> >This diff is against the latest 7-CURRENT rc.subr. I had to manually 
> >merge 3 hunks due to some differences.
> 
> Thanks!!  I've put the updated version (for 6-STABLE) here:
> 
> http://www.googlebit.com/freebsd/patches/rc_fancy.patch-2
> 
> 
> Gordon - can you give this version a try?

Much better now. :)

The [OK] Messages printed correctly. Some [failed] messages are missing
a \t I think. But this should be the error of the respective scripts.

Nice work so far... ;)

best regards,

	Gordon

-- 
Gordon Bergling <GBergling at 0xfce3.net>	      http://www.0xFCE3.net/
PGP Fingerprint:  7732 9BB1 5013 AE8B E42C  28E0 93B9 D32B C76F 02A0
RIPE-HDL: MDTP-RIPE				  "Minimal Electronic Music"


More information about the freebsd-hackers mailing list