portmanager

Michael C. Shultz ringworm01 at gmail.com
Thu Oct 13 05:52:03 PDT 2005


On Thursday 13 October 2005 04:37, you wrote:
> Michael C. Shultz wrote:
> > if ( getenv("TERM") )
> > {
> > 	. . .
> > }
>
> Anyway you should use code like that for the cases:
> char *term;
> term = getenv("TERM");
>
> And check the variable afterwards. It much better than call getenv() twice.
> And the first condition would be:
> if( term && !strncmp( term, "xterm", 5 ) && isatty(fileno(stdout)) )
>
> And some people not recomend use '!' with str[n]cmp(). Using '== 0' is
> better.
>
> It was someting about a code style.

Thanks for the good advice! I'll clean it up for the next change.

-Mike


More information about the freebsd-hackers mailing list