Kernel source hacking

Václav Haisman V.Haisman at sh.cvut.cz
Fri Nov 4 01:15:36 PST 2005



M. Warner Losh wrote:
> In message: <436A7474.4040501 at sh.cvut.cz>
>             Václav Haisman <V.Haisman at sh.cvut.cz> writes:
> : I have noticed that there are still places in kernel sources that use
> : K&R style of function parameter definitions.
> 
> You must be looking at old sources.  Most of the kernel has been
I noticed that in version 1.651 of vfs_subr.c on MAIN branch through
FreeBSD's CVSweb.

> converted, but it is still a work in progress.  There's very little
> gain for the risk that something subtle that's different between K&R
> and ANSI causes breakage...  The risk is much lower these days since
> we insist on proper prototypes...
I think there is very little risk, with proper patch review.

> 
> : Are the core developers interested in changing it into proper ANSI
> : definitions? I would do it because it would give me a reason to read the
> : code and learn something about the kernel.
> 
> Nearly all of the kernel has been converted.  The parts that remain
> are the less widely travelled paths through the code.
> 
> : Also, is there a page with other tasks for kernel neophytes like me? I
> : looked for some such page but I couldn't find any.
> 
> phk used to have a /jkh/ page, or Junior Kernel Hacker page.  Don't
> know if that's still that way or not.
> 
> Warner

Vaclav Haisman

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 546 bytes
Desc: OpenPGP digital signature
Url : http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20051104/419fd5b5/signature.bin


More information about the freebsd-hackers mailing list