Obvious bug in /sys/i386/include/bus.h
M. Warner Losh
imp at bsdimp.com
Tue Jun 14 01:26:55 GMT 2005
In message: <200506131412.38967.hselasky at c2i.net>
Hans Petter Selasky <hselasky at c2i.net> writes:
: So can someone have this fixed, or is there a reason not to fix it. The one
: who wrote the code has done the same mistake with every one of the
: bus_space_XXXX that does memory mapped I/O. It currently breaks my drivers.
One isn't supposed to call these routines with count == 0. One could
say your drivers are broken :-)
Back when these were written, small optimizations like this were made
to make things go faster. Now that cache sizes are bigger, a few
extra instructions likely wouldn't affect things too much. Best to
measure the effects of your proposed changes on real workloads...
Warner
More information about the freebsd-hackers
mailing list