Global (non _KERNEL) place for sockaddr_union?

[Brooks Davis]

On Mon, Sep 20, 2004 at 02:50:40AM +0200, Max Laier wrote:
> Hi,
> 
> http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/71836 is the symptom. Now I am 
> looking for a clean solution to it. What is needed is an include file that 
> defines union sockaddr_union in a way that is useable from kernel and 
> userland. Historically it seems that this union first apeared in context of 
> ipsec within the kernel. pf has adopted it, but uses it in the userland as 
> well. I am sure that it can be usefull in a lot of places that have to deal 
> with/store different address formats.
> 
> My question now is, what would be a good place to define this? Are there any 
> fromal standarts that might define it already? (Couldn't find anything) Is 
> there anything else that I must consider?
> 
> At some point I though netinet/in.h might be a good place, but that'd require 
> inclusion of sys/socket.h, which certainly is not a good solution.
> 
> Opinions? Ideas?
> 
> > #include <sys/socket.h>
> > #include <netinet/in.h>
> > 
> > union sockaddr_union {
> >  struct sockaddr   sa;
> >  struct sockaddr_in  sin;
> >  struct sockaddr_in6  sin6;
> >  struct sockaddr_storage __su_pad;  /* maybe not a bad idea */
> > };

I don't see an elegant solution.  Stuffing it off in its own file may
be the best thing if you're going to use it.  Overall, I'd say it's bad
idea that PF be better off without.  It appears to save a few casts,
but nothing worth the pain of generalizing the declaration.

-- Brooks

-- 
Any statement of the form "X is the one, true Y" is FALSE.
PGP fingerprint 655D 519C 26A7 82E7 2529  9BF0 5D8E 8BE9 F238 1AD4
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-hackers/attachments/20040919/347faf19/attachment.bin