non-recursive mutex, sbc, pcm, kernel panic

[John Baldwin]

On Sunday 09 May 2004 03:40 pm, Don Lewis wrote:
> Typically the proper fix in this case would be to remove the
> sb_lock() call from sb_reset_dsp() and always let the caller do the
> locking.  The patch below should do the trick, though I believe the
> added locking and unlocking (the second section of the patch) could be
> omitted in sb16_attach() since no other thread can access the device
> while the attach is in progress.

Just a nit: I would add an assertion that the lock is held when sb_reset_dsp() 
is called as both documentation and to ensure that all callers hold it during 
testing and future development.

-- 
John Baldwin <jhb at FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org