Anyone seen 4.8-RELEASE running on a real 386 (not 486 586 etc) ?

[Erik Trulsson]

On Mon, Apr 14, 2003 at 01:00:54AM +0200, Julian Stacey wrote:
> Erik Trulsson wrote:
> > On Thu, Apr 10, 2003 at 08:43:04PM +0200, Julian Stacey wrote:
> > > Anyone seen 4.8-RELEASE running on a real 386 processor (not a 486, 586 etc
> > 
> > Try the following patch.
> > Makes my 386sx/33 work fine at least.
> > (Without it I get the same panic as you do.)
> 
> This works :-)  I'm now running 4.8, Thanks !

You are welcome.
It seems that there can't be too many people trying to run 4.8 on a
real '386. Otherwise I would have expected at least someone else to
complain about 4.8 not working on their machine.


> 
> -----------
> 
> > From: John Baldwin <jhb at FreeBSD.org>
> 
> > > Try the following patch.
> > > Makes my 386sx/33 work fine at least.
> > > (Without it I get the same panic as you do.)
> > 
> > Oh my, I hope that isn't it.  If so it's my fault. :(
> > 
> > Hmm, can you try this patch instead?
> > 
> > http://www.FreeBSD.org/~jhb/patches/4x_386.patch
> 
> Thanks, but these patches Did Not fix the problem. They also did not apply
> cleanly to 4.8, perhaps made against current or stable ?

It applied cleanly to 4-stable so it was presumably made against that.

> whatever, it was easy to see what you intended, so I produced a 4.8
> compliant set, including both Erik's & yours commented out at:
> 
> http://www.berklix.com/~jhs/src/bsd/fixes/freebsd/src/gen/sys/i386/i386/i386_cpu.REL=4.8-RELEASE.diff
> 
> I'm not sure if Erik's one line patch is good to commit for all
> processors (I haven't read the logic, just know i fixes my 386).

My patch will not break anything.
John Baldwin has already committed my patch to the 4-stable branch.
His commit message (quoted below) explains what the problem was and why
my patch is not really the proper fix but will work.

  Modified files:        (Branch: RELENG_4)
    sys/i386/i386        identcpu.c
  Log:
  Revert one part of the last change so that cpu_class has a default value
  again.  Apparently some code in pmap reads the value of this variable
  before it is properly initialized.  That is a bug (!) but not a critical
  one and it is easier to make this change than hunt down that bug. This
  fixes booting on 80386 machines.
  Submitted by:   Erik Trulsson <ertr1013 at student.uu.se>
  Pointy hat to:  jhb
  Revision   Changes    Path
  1.80.2.15  +1 -1      src/sys/i386/i386/identcpu.c



> If anyone want to send me new patches to test before they commit,
> feel free.  Ideally that would be in next day or so, before I return
> machine to remote service (where boot failure is inconvenient, but
> I could test later too if necessary).
[snip]



-- 
<Insert your favourite quote here.>
Erik Trulsson
ertr1013 at student.uu.se