maintainer-approval requested: [Bug 253870] devel/libgtop: fails to build on head after commit 2bfd8992c7c7 : [Attachment 222851] Patch using sys/types.h

[bugzilla-noreply at freebsd.org]

Guido Falsi <madpilot at FreeBSD.org> has asked freebsd-gnome (Nobody)
<gnome at FreeBSD.org> for maintainer-approval:
Bug 253870: devel/libgtop: fails to build on head after commit 2bfd8992c7c7
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253870

Attachment 222851: Patch using sys/types.h
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=222851&action=edit



--- Comment #3 from Guido Falsi <madpilot at FreeBSD.org> ---
Created attachment 222851
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=222851&action=edit
Patch using sys/types.h

I'm using a slightly different patch.

Actually that bool type should be the one expected by kernel own sources, which
is defined in types.h

Hoisting it's inclusion and forcing _KERNEL defined warrants the correct
includes.

I'm not able to judge which one is the best approach.

Obviously I'm biased towards my own patch :)