maintainer-feedback requested: [Bug 253870] devel/libgtop: fails to build on head after commit 2bfd8992c7c7

[bugzilla-noreply at freebsd.org]

Bugzilla Automation <bugzilla at FreeBSD.org> has asked freebsd-gnome (Nobody)
<gnome at FreeBSD.org> for maintainer-feedback:
Bug 253870: devel/libgtop: fails to build on head after commit 2bfd8992c7c7
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=253870



--- Description ---
After updating to a recent head I noticed libgtop failing, with error at the
end of this message.

The mentioned commit add the bool return type to the inmem function.

I noticed this bool type is defined in sys/types.h, but only if _KERNEL is
defined.

So the first time it is included _KERNEL needs to be defined.

I'm trying to get a patch to that effect, but until now I've always been
missing some previous inclusion.

I'll followup with it as soon as I have a working patch.


In file included from procmap.c:54:
In file included from /usr/include/ufs/ufs/inode.h:50:
/usr/include/sys/buf.h:569:1: error: unknown type name 'bool'
bool	inmem(struct vnode *, daddr_t);
^
procmap.c:101:25: warning: unused variable 'um' [-Wunused-variable]
	struct ufsmount um;
			^
procmap.c:405:16: warning: cast from 'gchar *' (aka 'char *') to
'glibtop_map_entry *' (aka 'struct _glibtop_map_entry *') increases required
alignment from 1 to 8 [-Wcast-align]
	return (glibtop_map_entry*) g_array_free(maps, FALSE);
	       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2 warnings and 1 error generated.
gmake[4]: *** [Makefile:573: procmap.lo] Error 1
gmake[4]: *** Waiting for unfinished jobs....