[Bug 237822] x11-toolkits/pango: Fails to configure with DOCS=ON X11=OFF: ERROR: Unknown variable "xft_dep". (since 1.42.4_2, ports r500960)

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237822

--- Comment #29 from Ting-Wei Lan <lantw44 at gmail.com> ---
Comment on attachment 206190
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=206190
patch-docs_meson.build

>--- docs/meson.build.orig	2019-07-31 21:41:55 UTC
>+++ docs/meson.build
>@@ -40,7 +40,7 @@ if host_system != 'darwin'
>   ]
> endif
> 
>-if host_system != 'windows'
>+if host_system == 'windows'
>   private_headers += [
>     'pangocairo-win32.h',
>     'pangowin32.h',

This is wrong. When you are not building for Windows, you have to ignore
headers which are specific to Windows. Therefore, it is correct to add
Windows-specific headers to private_headers because the variable is used to
prevent gtk-doc from scanning these headers. I think what you should change is
the else clause below because it doesn't look correct to assume xft is
available when host_system != 'windows'.

>@@ -68,7 +68,7 @@ if build_pangoft2
>   docdeps += libpangoft2_dep
> endif
> 
>-if xft_dep.found()
>+if libpangoxft_dep.found()
>   docdeps += libpangoxft_dep
> endif
> 

What does this change do? Isn't libpangoxft_dep only declared as a real
dependency when xft_dep is found?

I wonder why we have to provide xft option in ports. It doesn't exist in the
upstream project.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.