maintainer-feedback requested: [Bug 225206] devel/xdg-utils: xdg-mime has bogus patch to use stat -f

[bugzilla-noreply at freebsd.org]

John Hein <z7dr6ut7gs at snkmail.com> has reassigned Bugzilla Automation
<bugzilla at FreeBSD.org>'s request for maintainer-feedback to gnome at FreeBSD.org:
Bug 225206: devel/xdg-utils: xdg-mime has bogus patch to use stat -f
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225206



--- Description ---
Created attachment 189782
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=189782&action=edit
[patch] remove incorrect stat -f patch in favor of [now] fully supported
readlink -f

'stat -f <file>' has never been correct, but now the patch to use it instead of
readlink -f is unnecessary.  readlink -f has worked since freebsd 8, so ust
remove the bogus stat -f.

I think 'stat -f' was an attempt to work around the absence of '-f' for
readlink in freebsd before 8.x.  But it's just an invalid invocation of stat
that basically winds up doing nothing as used in xdg-mime.  It certainly does
not follow all links to get the filename of the link target.

One could file a bug with stat where 'stat -L -F %N <file>' reports the name of
a link (if <file> is a sym link) instead of the link target.  Maybe that's what
was originally intended as a replacement for readlink -f.  But that's a
separate bug and such a replacement is no longer needed for xdg-mime.