maintainer-feedback requested: [Bug 225123] deskutils/gnome-contacts: unbreak build with vala 0.36

[bugzilla-noreply at freebsd.org]

Carlos J. Puga Medina <cpm at freebsd.org> has reassigned Bugzilla Automation
<bugzilla at FreeBSD.org>'s request for maintainer-feedback to gnome at FreeBSD.org:
Bug 225123: deskutils/gnome-contacts: unbreak build with vala 0.36
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225123



--- Description ---
Created attachment 189669
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=189669&action=edit
patch

folks-telepathy.vapi:33.3-33.54: error: Type and/or accessors of overriding
property `Tpf.PersonaStore.personas' do not match overridden property
`Folks.PersonaStore.personas': incompatible get accessor type.
		public override Gee.Map<string,Tpf.Persona> personas { get; }
		^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
folks-telepathy.vapi:33.3-33.54: error: Tpf.PersonaStore.personas: no suitable
property found to override
		public override Gee.Map<string,Tpf.Persona> personas { get; }
		^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
folks-eds.vapi:46.3-46.55: error: Type and/or accessors of overriding property
`Edsf.PersonaStore.personas' do not match overridden property
`Folks.PersonaStore.personas': incompatible get accessor type.
		public override Gee.Map<string,Edsf.Persona> personas { get; }
		^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
folks-eds.vapi:46.3-46.55: error: Edsf.PersonaStore.personas: no suitable
property found to override
		public override Gee.Map<string,Edsf.Persona> personas { get; }
		^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
contacts-store.vala:331.31-331.64: warning:
TelepathyGLib.AccountManager.get_valid_accounts is deprecated
contacts-address-map.vala:55.50-55.72: warning:
Champlain.MAP_SOURCE_OSM_MAPQUEST is deprecated
contacts-address-map.vala:68.41-68.69: warning: Gdk.Cursor.new has been
deprecated since 3.16
contacts-contact-editor.vala:680.19-680.30: error: Expected initializer of type
`Folks.AbstractFieldDetails<string>' but got `Folks.PostalAddressFieldDetails'
	rows.set (row, { detail_field });
			 ^^^^^^^^^^^^
contacts-contact-editor.vala:680.17-680.17: error: Invalid type for argument 2
	rows.set (row, { detail_field });
		       ^
contacts-contact-editor.vala:687.23-687.26: error: Expected initializer of type
`Folks.AbstractFieldDetails<string>' but got `Folks.PostalAddressFieldDetails'
	    rows.set (row, { addr });
			     ^^^^
contacts-contact-editor.vala:687.21-687.21: error: Invalid type for argument 2
	    rows.set (row, { addr });
			   ^
contacts-contact-pane.vala:314.17-314.72: warning: unhandled error `GLib.Error'
      var pix = icon_theme.load_icon ("avatar-default-symbolic", 144, 0);
		^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
contacts-contact-pane.vala:480.15-486.55: error: Too many arguments for
specified format
Compilation failed: 9 error(s), 26 warning(s)

build log:
http://pb2.nyi.freebsd.org/data/111i386-default-PR221941/2018-01-09_20h28m24s/l
ogs/gnome-contacts-3.18.0_6.log