maintainer-approval requested: [Bug 219608] print/freetype2 produces incorrect line spacing for some fonts : [Attachment 183251] Proposed patch for print/freetype2 (since 441132)

[bugzilla-noreply at freebsd.org]

lightside <lightside at gmx.com> has asked gnome at FreeBSD.org for
maintainer-approval:
Bug 219608: print/freetype2 produces incorrect line spacing for some fonts
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219608

Attachment 183251: Proposed patch for print/freetype2 (since 441132)
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=183251&action=edit



--- Comment #18 from lightside <lightside at gmx.com> ---
Created attachment 183251
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=183251&action=edit
Proposed patch for print/freetype2 (since 441132)

> I would like something to clarify the meaning of the TT_SIZE_METRICS_ALL
> option, though. I don't think much of anyone will realize what it means
> (not that I have a better idea. I'd really like "Restore traditional TrueType
> line spacing", but that is not quite correct.
It was "TT_SIZE_METRICS_ALT", but showed in terminal as "TT_SIZE_METRICS_AL".
The _ALT postfix used as for "alternative" meaning.

I decided to rename TT_SIZE_METRICS_ALT option to FIX_SIZE_METRICS with
following description: "Fix metrics on size request for scalable fonts
(alternative method)". The main part of description is used from following
commit:
"[truetype] Fix metrics on size request for scalable fonts."
http://git.savannah.gnu.org/cgit/freetype/freetype2.git/commit/?id=b0962ac34e66
052ccfee7996e5468f30d4bd5a72

Also created OPTIONS_RADIO (0 or 1 among N) for FIX_SIZE_METRICS and
TT_SIZE_METRICS options, because they are alternative methods, in my opinion,
but implemented in different places (TrueType driver (src/truetype/ttdriver.c)
or auto-hinter/auto-fitter code (src/autofit/afloader.c)).