[Bug 211201] print/freetype2: update to 2.6.5, replace LCD_FILTERING with V40 code

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sat Jul 23 18:55:54 UTC 2016


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211201

--- Comment #27 from Jan Beich <jbeich at FreeBSD.org> ---
Comment on attachment 172904
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=172904
Proposed patch (since 412348 revision)

> +.include <bsd.port.pre.mk>
> +
> +.if defined(SUBPIXEL_HINTING_MODE)
> +CFLAGS+=	-DTT_CONFIG_OPTION_SUBPIXEL_HINTING=${SUBPIXEL_HINTING_MODE:ts|:Q}

bsd.port.pre.mk can also be dropped via :D modifier.

  CFLAGS+=     
${SUBPIXEL_HINTING_MODE:D-DTT_CONFIG_OPTION_SUBPIXEL_HINTING=${SUBPIXEL_HINTING_MODE:ts|:Q}}

As the line abused horizontal space comment 23 went with option helpers instead
and a side effect of duplicated CFLAGS. Those are harmless but can still be
fixed by :u modifier.

  .include <bsd.port.options.mk>

  CFLAGS:=      ${CFLAGS:u}

I'm sure there're better ways to utilize bmake features in ports but let's not
forget that FreeBSD 9.x still use fmake where :ts and :D are not supported.

  $ make
  Unknown modifier 't'

One way to plan for the future EOL (circa 2017-01-01) is to introduce .if
defined(.PARSEDIR) conditionals.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.


More information about the freebsd-gnome mailing list