maintainer-approval requested: [Bug 211684] audio/pulseaudio: Respect hw.snd.default_unit : [Attachment 173625] Proposed patch (since 419133 revision) for v8.0

[bugzilla-noreply at freebsd.org]

lightside <lightside at gmx.com> has asked gnome at FreeBSD.org for
maintainer-approval:
Bug 211684: audio/pulseaudio: Respect hw.snd.default_unit
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211684

Attachment 173625: Proposed patch (since 419133 revision) for v8.0
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=173625&action=edit



--- Comment #11 from lightside <lightside at gmx.com> ---
Created attachment 173625
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=173625&action=edit
Proposed patch (since 419133 revision) for v8.0

I changed parsing algorithm to find last occurrence of '>' character, which may
exclude (possible) usage of "> (" along with "play" or "rec" words in device
name. This conforms to current format of output in sndstat source code:
on FreeBSD:
https://github.com/freebsd/freebsd/blob/4a8d8f7fba6ae0abcfae7ee40db2bcf9b563fe0
1/sys/dev/sound/pcm/sndstat.c#L361
https://github.com/freebsd/freebsd/blob/4a8d8f7fba6ae0abcfae7ee40db2bcf9b563fe0
1/sys/dev/sound/pcm/sndstat.h#L49
and DragonFlyBSD:
https://github.com/DragonFlyBSD/DragonFlyBSD/blob/d78ce965185bbe24349ec52eeb17e
712b8a0d8dc/sys/dev/sound/pcm/sndstat.c#L399
https://github.com/DragonFlyBSD/DragonFlyBSD/blob/d78ce965185bbe24349ec52eeb17e
712b8a0d8dc/sys/dev/sound/pcm/sndstat.h#L49