maintainer-feedback requested: [Bug 195452] editors/abiword: probably incorrect option group handling

[bugzilla-noreply at freebsd.org]

Dmitry Marakasov <amdmi3 at FreeBSD.org> has asked gnome at FreeBSD.org for
maintainer-feedback:
Bug 195452: editors/abiword: probably incorrect option group handling
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195452



--- Description ---
abiword has options group named COLLAB:

OPTIONS_GROUP=	COLLAB
OPTIONS_GROUP_COLLAB=	COLXMPP

however group name is mentioned in OPTIONS_DEFAULT:

OPTIONS_DEFAULT=SPELLCHECK CLIPART TEMPLATES COLLAB

and is checked later

.if ${PORT_OPTIONS:MCOLLAB}
CONFIGURE_ARGS+=--with-boost --enable-collab-backend-tcp \
		--enable-collab-backend-service
BUILD_DEPENDS+= ${LOCALBASE}/include/asio.hpp:${PORTSDIR}/net/asio
LIB_DEPENDS+=	libboost_system.so:${PORTSDIR}/devel/boost-libs \
		libsoup-2.4.so:${PORTSDIR}/devel/libsoup \
		libgnutls.so:${PORTSDIR}/security/gnutls
RUN_DEPENDS+=	${LOCALBASE}/include/asio.hpp:${PORTSDIR}/net/asio
PLIST_SUB+=		COLLAB=""
.else
CONFIGURE_ARGS+=--without-boost --disable-collab-backend-tcp \
		--disable-collab-backend-service
PLIST_SUB+=		COLLAB="@comment "
.endif

this seems to be incorrect - I haven't digged into the logic, but probably
COLXMPP which belongs to COLLAB group should be mentioned in OPTIONS_DEFAULT
and checked instead.

--- Comment #1 from Bugzilla Automation <bugzilla at FreeBSD.org> ---
Auto-assigned to maintainer gnome at FreeBSD.org