maintainer-feedback requested: [Bug 195601] [patch] archivers/file-roller 3.14.1 fails to build on FreeBSD 8.4

[bugzilla-noreply at freebsd.org]

Don Lewis <truckman at FreeBSD.org> has reassigned Bugzilla Automation
<bugzilla at FreeBSD.org>'s request for maintainer-feedback to gnome at FreeBSD.org:
Bug 195601: [patch] archivers/file-roller 3.14.1 fails to build on FreeBSD 8.4
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=195601



--- Description ---
Created attachment 150134
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=150134&action=edit
patch to fix build of archivers/file-roller 3.14.1 on FreeBSD 8.4

The archivers/file-roller version 3.14.1 port fails to build on FreeBSD 8.4:

  CC	   fr-command-tar.o
fr-command-lrzip.c: In function 'list__process_line':
fr-command-lrzip.c:48: error: 'struct stat' has no member named 'st_mtim'
Makefile:720: recipe for target 'fr-command-lrzip.o' failed
gmake[4]: *** [fr-command-lrzip.o] Error 1
gmake[4]: *** Waiting for unfinished jobs....
gmake[4]: Leaving directory
'/wrkdirs/usr/ports/archivers/file-roller/work/file-roller-3.14.1/src'
Makefile:753: recipe for target 'all-recursive' failed
gmake[3]: *** [all-recursive] Error 1
gmake[3]: Leaving directory
'/wrkdirs/usr/ports/archivers/file-roller/work/file-roller-3.14.1/src'
Makefile:551: recipe for target 'all' failed
gmake[2]: *** [all] Error 2
gmake[2]: Leaving directory
'/wrkdirs/usr/ports/archivers/file-roller/work/file-roller-3.14.1/src'
Makefile:496: recipe for target 'all-recursive' failed
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory
'/wrkdirs/usr/ports/archivers/file-roller/work/file-roller-3.14.1'
Makefile:425: recipe for target 'all' failed
gmake: *** [all] Error 2
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1

Stop in /usr/ports/archivers/file-roller.


In FreeBSD 8.4 this member of struct stat is named st_mtimespec.  In the early
days of FreeBSD 9 (after the branch but before 9.0-RELEASE), it was renamed to
st_mtim in src rev r205792 for POSIX 2008 compliance.  This change was never
merged back to 8-STABLE.  There was no corresponding bump of __FreeBSD_version,
but the change happened between 900010 and 900011.

The attached patch tweaks the source to use the old name when building on
FreeBSD 8.4.

--- Comment #1 from Bugzilla Automation <bugzilla at FreeBSD.org> ---
Auto-assigned to maintainer gnome at FreeBSD.org