What `gnometarget` is bsd.gnome.mk?

[Joe Marcus Clarke]

On 8/9/11 11:01 AM, Ruslan Mahmatkhanov wrote:
> Koop Mast wrote on 09.08.2011 14:27:
>> On Tue, 2011-08-09 at 14:13 +0400, Ruslan Mahmatkhanov wrote:
>>> Koop Mast wrote on 09.08.2011 13:53:
>>>> On Tue, 2011-08-09 at 13:31 +0400, Ruslan Mahmatkhanov wrote:
>>>>> Joe Marcus Clarke wrote on 09.08.2011 10:39:
>>>>>> On 8/8/11 3:10 PM, Ruslan Mahmatkhanov wrote:
>>>>>>>
>>>>>>> This component is defined in _USE_GNOME_ALL and i see it in
>>>>>>> USE_GNOME in
>>>>>>> some ports. But it doesn't seemed used. What it's for?
>>>>>>>
>>>>>>> PS. I wasn't able to find anything in Porters Handbook and GNOME
>>>>>>> porting
>>>>>>> guide.
>>>>>>>
>>>>>>
>>>>>> Looks like this can be removed now.  We used to have a special
>>>>>> CONFIGURE_TARGET for GNOME ports.  If you look back through CVS
>>>>>> history
>>>>>> you can see what this did.
>>>>>>
>>>>>> Joe
>>>>>
>>>>> Thank you.
>>>>> Here is the ports, that define USE_GNOME, and `gnometarget` is the
>>>>> only
>>>>> component, so USE_GNOME may be eliminated completely in this ports:
>>>>>
>>>>> http://pastebin.com/vpeX4r8K
>>>>>
>>>>> All the other ports that define `gnometarget` in USE_GNOME along with
>>>>> other components:
>>>>>
>>>>> http://pastebin.com/7j3FcEM7
>>>>>
>>>>> Should i make pr, patches?
>>>>>
>>>>
>>>> I just reverted this commit since it broke 553 ports. I filed a pr
>>>> 159624 to track this issue.
>>>>
>>>> -Koop
>>>
>>> Ok. To be honest i didn't requested the deletion, just was curious what
>>> it is for :).
>>>
>>
>> Well you brought it to our attention, that is enough in my book :)
>> Anyway if you want to make a patch for this for all the ports, feel free
>> to attach it to the pr. If not, someone will deal with this.
>>
>> -Koop
> 
> Ok. I did the followup to pr with patch attached.
> My first mass-murder experience :)
> 
> 

Careful, it can get addictive.

Joe

-- 
Joe Marcus Clarke
FreeBSD GNOME Team	::	gnome at FreeBSD.org
FreeNode / #freebsd-gnome
http://www.FreeBSD.org/gnome