graphics/librsvg2: build fail using WITH_MOZILLA_PLUGIN

[Koop Mast]

On Sun, 2009-11-29 at 16:10 +0100, barbara wrote:
> Trying to install librsvg2-2.26.0_2, I've got an error using WITH_MOZILLA_PLUGIN. Without that option it builds as expected.

I CC'd the gecko team. They are doing a gecko rework. 
Can you take a look at this? It seems you broke librsvg2 mozilla plugin.

-Koop

> ----------------------------------------------------------------
> Making all in moz-plugin
> gmake[2]: Entering directory `/usr/ports/graphics/librsvg2/work/librsvg-2.26.0/moz-plugin'
> /bin/sh /usr/ports/graphics/librsvg2/work/gnome-libtool --tag=CC   --mode=compile cc -DHAVE_CONFIG_H -I. -I.. -I/usr/local/include/libxul/stable -I/usr/local/include/nspr   -DBINDIR=\"/usr/local/bin/\" -D_REENTRANT -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include   -D_THREAD_SAFE -I/usr/local/include/gtk-2.0 -I/usr/local/lib/gtk-2.0/include -I/usr/local/include/pango-1.0 -I/usr/local/include -I/usr/local/include/cairo -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/pixman-1 -I/usr/local/include/freetype2     -I/usr/local/include  -O2 -pipe -fno-strict-aliasing -march=athlon-mp -MT moz-plugin.lo -MD -MP -MF .deps/moz-plugin.Tpo -c -o moz-plugin.lo moz-plugin.c
> gnome-libtool: compile:  cc -DHAVE_CONFIG_H -I. -I.. -I/usr/local/include/libxul/stable -I/usr/local/include/nspr -DBINDIR=\"/usr/local/bin/\" -D_REENTRANT -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -D_THREAD_SAFE -I/usr/local/include/gtk-2.0 -I/usr/local/lib/gtk-2.0/include -I/usr/local/include/pango-1.0 -I/usr/local/include -I/usr/local/include/cairo -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/pixman-1 -I/usr/local/include/freetype2 -I/usr/local/include -O2 -pipe -fno-strict-aliasing -march=athlon-mp -MT moz-plugin.lo -MD -MP -MF .deps/moz-plugin.Tpo -c moz-plugin.c  -fPIC -DPIC -o .libs/moz-plugin.o
> gnome-libtool: compile:  cc -DHAVE_CONFIG_H -I. -I.. -I/usr/local/include/libxul/stable -I/usr/local/include/nspr -DBINDIR=\"/usr/local/bin/\" -D_REENTRANT -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -D_THREAD_SAFE -I/usr/local/include/gtk-2.0 -I/usr/local/lib/gtk-2.0/include -I/usr/local/include/pango-1.0 -I/usr/local/include -I/usr/local/include/cairo -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/pixman-1 -I/usr/local/include/freetype2 -I/usr/local/include -O2 -pipe -fno-strict-aliasing -march=athlon-mp -MT moz-plugin.lo -MD -MP -MF .deps/moz-plugin.Tpo -c moz-plugin.c -o moz-plugin.o >/dev/null 2>&1
> mv -f .deps/moz-plugin.Tpo .deps/moz-plugin.Plo
> /bin/sh /usr/ports/graphics/librsvg2/work/gnome-libtool --tag=CC   --mode=link cc  -O2 -pipe -fno-strict-aliasing -march=athlon-mp -module -avoid-version  -L/usr/local/lib -o libmozsvgdec.la -rpath  moz-plugin.lo -pthread -L/usr/local/lib -lgthread-2.0 -lglib-2.0   
> gmake[2]: Leaving directory `/usr/ports/graphics/librsvg2/work/librsvg-2.26.0/moz-plugin'
> gmake[1]: Leaving directory `/usr/ports/graphics/librsvg2/work/librsvg-2.26.0'
> *** Error code 1
> 
> Stop in /usr/ports/graphics/librsvg2.
> *** Error code 1
> 
> Stop in /usr/ports/graphics/librsvg2.
> ----------------------------------------------------------------
> 
> It seems that the path after "-rpath" is missing.
> Looking at the differences between Makefile.in.bak and Makefile.in in work/librsvg-2.26.0/moz-plugin, I think the the problem is the removal of the inclusion of Makefile.webplugins, because ${WEBPLUGINS_DIR} would be "" in post-patch phase.
> 
> So this could be the patch:
> ----------------------------------------------------------------
> --- Makefile.orig       2009-11-28 21:05:44.000000000 +0100
> +++ Makefile    2009-11-29 15:30:47.000000000 +0100
> @@ -49,6 +49,7 @@
>  USE_GECKO=     libxul seamonkey
>  USE_WEBPLUGINS=        gecko19
>  WEBPLUGINS_FILES=libmozsvgdec.so
> +.include "${PORTSDIR}/www/firefox/Makefile.webplugins"
>  CONFIGURE_ENV+=        MOZILLA_CONFIG=no
>  CONFIGURE_ARGS+=--enable-mozilla-plugin=yes
> ----------------------------------------------------------------
> 
> 
> 
> Thanks
> Barbara