Question about updating guile to 1.8

[Joe Marcus Clarke]

On Mon, 2008-02-25 at 08:38 -0800, Amatus wrote:
> --- Joe Marcus Clarke <marcus at marcuscom.com> wrote:
> 
> > 
> > On Sun, 2008-02-24 at 18:07 -0800, Amatus wrote:
> > > --- Joe Marcus Clarke <marcus at marcuscom.com> wrote:
> > > 
> > > > 
> > > > On Sun, 2008-02-24 at 14:24 -0800, Amatus wrote:
> > > > > Hi guys,
> > > > > I'm working on updating lang/guile to 1.8.
> > > > 
> > > > Excellent.
> > > > 
> > > > >  I've basically got that
> > > > > working but there are several other ports that refer to
> > > > > ${LOCALBASE}/share/guile/1.6 that will need to be fixed. These
> > are:
> > > > > security/lsh
> > > > > lang/slib-guile
> > > > > finance/gnucash
> > > > > I've just started doing port development so I'd like to ask
> > what is
> > > > the
> > > > > correct way to fix these ports. What do you guys think of the
> > > > attached
> > > > > patch for lang/slib-guile?
> > > > 
> > > > This patch is okay.  But note that GUILE_VERSION is not expanded
> > > > until
> > > > it is used in sh.  That is, GUILE_VERSION does NOT equal "1.8". 
> > You
> > > > will not be able to make it equal "1.8" until it is interpreted
> > by
> > > > sh.
> > > > The way you're using it here is fine, though.
> > > > 
> > > > As for the command itself, it should probably be:
> > > > 
> > > > `${LOCALBASE}/bin/guile-config info guileversion | ${CUT} -f 1-2
> > -d
> > > > .`
> > > > 
> > > > Are you in a position to be run-time testing these ports with the
> > new
> > > > guile?  Once you're done with your work, do you want to be the
> > guile
> > > > maintainer?
> > > > 
> > > > Joe
> > > 
> > > I realize it's not expanded immediately. I know in GNU make there
> > is
> > > the $(shell) syntax for doing that but I didn't find a way to do
> > that
> > > in BSD make. Do you know the Right Way?
> > 
> > The way you're doing it is probably best.  The way you submitted in
> > the
> > PR, while it may look correct, will most likely break INDEX when
> > guile
> > is not installed.   Try it.  Uninstall guile, then cd to lang/slib,
> > and
> > run "make describe".  Use of != is discouraged for commands which are
> > not in the base system.
> > 
> > Joe
> 
> I uninstalled guile and make describe worked fine with some noise on
> stderr.

What output?  Any output on stderr is bad.

>  I'm running into more problems with gnucash and lsh using
> RUN_DEPENDS. I need to .include <bsd.port.pre.mk> before the != but if
> I move it up too high in the file (before RUN_DEPENDS) then make
> breaks. Would it be ok to just edit the dependency to be
> "slib-guile>=3a4:${PORTSDIR}/lang/slib-guile" instead of
> "${LOCALBASE}/share/guile/1.6/slibcat:${PORTSDIR}/lang/slib-guile"?

This is fine.  Also, there's no dishonor in hardcoding the guile
version.  It may look ugly, but guile's minor version hasn't changed
much, and it's not too hard to chase.

Joe

-- 
PGP Key : http://www.marcuscom.com/pgp.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/freebsd-gnome/attachments/20080225/bb68efde/attachment.pgp