Fix for x11/gnome-screensaver

Joe Marcus Clarke marcus at marcuscom.com
Wed May 2 06:41:13 UTC 2007


On Tue, 2007-05-01 at 23:24 -0700, Brian Somers wrote:
> On Tue, 1 May 2007 12:36:16 -0700 Brian Somers <brians at ca.sophos.com> wrote:
> > Hi,
> > 
> > Could someone apply the attached patch for x11/gnome-screensaver
> > or approve it for me to commit?
> > 
> > TIA.
> > 
> > -- 
> > Brian Somers                                       Tel: +1 604 484 6434
> >                                                    Mob: +1 604 315 1343
> > Sophos - security and control                      Web:  www.sophos.com
> > 
> > Index: Makefile
> > ===================================================================
> > RCS file: /usr/home/ncvs/ports/x11/gnome-screensaver/Makefile,v
> > retrieving revision 1.23
> > diff -u -r1.23 Makefile
> > --- Makefile	11 Apr 2007 13:32:59 -0000	1.23
> > +++ Makefile	1 May 2007 19:34:17 -0000
> > @@ -47,7 +47,7 @@
> >  CONFIGURE_ARGS+=	--disable-pam
> >  .endif
> >  
> > -pre-install:
> > +pre-su-install:
> >  	@${CP} ${.CURDIR}/pkg-plist ${PLIST}
> >  	@cd ${XSCREENSAVER_DIR} && ${FIND} -s * -maxdepth 1 -type f -name "*.xml" | \
> >  		${GREP} -Ev ${XSCREENSAVER_EXCLUDE} | \
> > @@ -55,7 +55,7 @@
> >  		${SED} -e 's:[.]xml$$:.desktop:' >> ${PLIST}
> >  	@${ECHO_CMD} @dirrm ${SCREENSAVER_DIR} >> ${PLIST}
> >  
> > -post-install:
> > +post-su-install:
> >  	${CHOWN} root ${PREFIX}/libexec/gnome-screensaver-dialog
> >  	${CHMOD} +s ${PREFIX}/libexec/gnome-screensaver-dialog
> >  	${MKDIR} ${PREFIX}/${SCREENSAVER_DIR}
> 
> Hmm, it seems that post-su-install doesn't exist and
> post-install is run with root credentials, so please
> disregard the second part of the patch.
> 
> The pre-install -> pre-su-install change is still
> required though...

Please see my earlier response to you.  I don't see why pre-su-install
is required here.

Joe

-- 
PGP Key : http://www.marcuscom.com/pgp.asc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/freebsd-gnome/attachments/20070502/ca2a798d/attachment.pgp


More information about the freebsd-gnome mailing list