Patch to add more GEOM support to hal

[Jean-Yves Lefort]

On Tue, 24 Oct 2006 10:23:44 -0400
Joe Marcus Clarke <marcus at FreeBSD.org> wrote:

> If you currently use a lot of different GEOM classes, and have noticed
> some strange hal-related behavior in GNOME when it comes to mounting
> disks, or seeing icons for RAID members on the desktop, try the
> following patch for sysutils/hal:
>
> http://www.marcuscom.com/downloads/patch-geom
>
> This patch removes libdisk usage from hal, and replaces it with pure
> GEOM configuration parsing.  I'm interested in getting all feedback.
> The idea is to fix any GEOM-related volume problems without introducing
> anything new.  So if something feels worse after this patch, definitely
> let me know.

- What are these GEOM problems?

- Memory leak:

         fields = g_strsplit(lines[i], " ", 0);
  -      if (g_strv_length(fields) >= 3 && ! strcmp(fields[1], "DISK"))
  +      if (g_strv_length(fields) < 3)
  +        continue;

- Don't forget to remove -ldisk from Makefile.am

- Why these explicit conversions?

  +	  sibling_geom = g_hash_table_lookup(hf_storage_geom_hash,
  +                                             (gconstpointer) sibling->data);
                                                ^^^^^^^^^^^^^^^

  +          geom_obj->mediasize = (guint64) strtoumax(fields[3], (char **) NULL, 10);
                                   ^^^^^^^^^                      ^^^^^^^^^

  (and so on)

--
Jean-Yves Lefort

jylefort at FreeBSD.org
http://lefort.be.eu.org/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-gnome/attachments/20061025/1343ec26/attachment.pgp