Can somebody please have a look at ports/78931?

[Jeremy Messenger]

On Wed, 20 Apr 2005 13:32:50 -0500, Miguel Mendez  
<flynn at energyhq.es.eu.org> wrote:

> On Wed, 20 Apr 2005 13:11:56 -0500
> "Jeremy Messenger" <mezz7 at cox.net> wrote:
>
>> Not useful to me, but it's up to someone in my team if he likes OPTIONS
>> stuff. Anyway, I took a bit look at it and I don't think few knobs will
>
> Could you elaborate on why you don't think OPTIONS are useful? I'm
> honestly interested.
>
>> work because of the OPTIONS don't work with the autocheck very well. I
>> only see useful in your PR is that two knobs that have exist() should be
>> move under .include <bsd.port.pre.mk> and change DATADIR in plist.
>
> I did test builds with BATCH=yes and it worked fine. If there's
> anything wrong I'd love to know about it.

Nevermind, I thought the RSVG2 has '.if ${HAVE_GNOME:Mlibrsvg2}!=""'.. The  
bsd.gnome.mk doesn't work with OPTIONS yet.

> To make it clear: Whether the
> consensus is to get it in the tree or drop it, it's fine. What I'd like
> to avoid is to have the PR sitting in limbo for months.

If nobody touch this PR for two more weeks or more maybe in May, then I  
will taking and commit it w/out add OPTIONS stuff then close it. That  
should give my team plenty of time if they want to add OPTIONS or make any  
comment on it.

Cheers,
Mezz

> Cheers,


-- 
mezz7 at cox.net  -  mezz at FreeBSD.org
FreeBSD GNOME Team
http://www.FreeBSD.org/gnome/  -  gnome at FreeBSD.org