fixes and comments on the upgrade script procedure

[Fernan Aguero]

Hi!

I'm running the upgrade script since yesterday ... I hoped
to have it finished by now,  but anyway ... since I had
some spare time, and lacking a better thing to
do I decided to read the upgrade script :) 

Attached is a diff with what I think should be corrected.

Also, it seems that though not explicitly specified in the
script, the upgrade procedure tried to rebuild openoffice.
This together with mozilla and firefox helps explain the
long time it is taking. Apart from the time issue, what
happened is that the attempt to build OOo made the upgrade
fail when /usr filled up. I never build OOo from sources,
and always use packages. I just don't have the space to
build such a monster. Perhaps it may be possible to perform a
'dry-run' of the script, just checking what would be done
and thus allow the user to exclude some beasts?

Fernan

-- 
Fernán Agüero | Instituto de Investigaciones Biotecnológicas
email         | fernan at { iib.unsam.edu.ar , mail.retina.ar }
wwww          | http://genoma.unsam.edu.ar/~fernan
phone, fax    | +54 11 { 4580-7255 ext 310, 4752-9639 }
-------------- next part --------------
--- gnome_upgrade.sh.orig	Tue Nov  9 17:33:51 2004
+++ gnome_upgrade.sh	Tue Nov  9 17:36:41 2004
@@ -4,7 +4,7 @@
 # ##################################################################
 # ## If you want to upgrade your GNOME desktop from 2.6 to 2.8,   ##
 # ## you're on the right track! Read our upgrade FAQ at           ##
-# ## http://www.freebsd.org/gnome/docs/faq26.html for complete    ##
+# ## http://www.freebsd.org/gnome/docs/faq28.html for complete    ##
 # ## instructions!                                                ##
 # ##################################################################
 # ##################################################################
@@ -396,7 +396,7 @@
     for i in ${POSTINSTALL_PORTS}; do
         echo -n "===> Installing ${i} ..."
         echo "===> Installing ${i} ..." >> ${logfile}
-        run_portupgrade ${logfile} ${logfile}
+        run_portupgrade ${logfile} ${i}
         if [ $? != 0 ]; then
             echo "FAILED."
             echo "===> Failed to install ${i}.  Please install this port by hand.  The output of the failed build is in ${logfile}.  If you require additional assistance reinstalling this port, please compress ${logfile} and send it to ${SUPPORT_EMAIL}." | /usr/bin/fmt 75 79