Any plan to get bsd.gnome.mk works w/ OPTIONS?

[Joe Marcus Clarke]

On Fri, 2004-04-30 at 12:48, Jeremy Messenger wrote:
> Hello,
> 
> I am a maintainer of x11-wm/fluxbox-devel and I just changed from 
> pre-everything to OPTIONS. So, I noticed that it needs the OPTIONS to be 
> add in the bsd.gnome.mk. Do anyone have any plan? I tried to do it by 
> myself (for now) like this for example:
> 
> ===================================
> WANT_GNOME=	yes
> 
> OPTIONS=	GNOME "Enable GNOME support" on
> 
> .include <bsd.port.pre.mk>
> 
> .if ${HAVE_GNOME:Mlibgnome}!=""
> CONFIGURE_ARGS+=	--enable-gnome
> .else
> CONFIGURE_ARGS+=	--disable-gnome
> .endif
> 
> .include <bsd.port.post.mk>
> ===================================
> 
> It will not listen to the OPTIONS if the user turn it off, but will listen 
> to the 'make -DWITHOUT_GNOME'.

That's because OPTIONS are processed after bsd.gnome.mk is included in
bsd.port.post.mk.

> 
> I am wondering what are the plan for this like remove GNOME from OPTIONS 
> and it will be done by automatic by bsd.gnome.mk or should I keep GNOME in 
> OPTIONS? Just want to ask so I can have it ready early. :-)

There is no plan to add OPTIONS directly into bsd.gnome.mk.  However,
OPTIONS may get an overhaul at some point so that the above will work. 
For now, I would leave things to bsd.gnome.mk, or add another check in
your Makefile:

.if ${HAVE_GNOME:Mlibgnome}!="" && !defined(WITHOUT_GNOME)

Joe

> 
> Cheers,
> Mezz
-- 
PGP Key : http://www.marcuscom.com/pgp.asc


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 187 bytes
Desc: This is a digitally signed message part
Url : http://lists.freebsd.org/pipermail/freebsd-gnome/attachments/20040430/4b54927a/attachment.bin