Speeding up gnome2 installation

[Thomas Quinot]

The pkg-install script for gnome currently runs pkg_info in a loop,
which is costly if many packages are stored under /usr/ports/packages.
I'd like to suggest that pkg_info be run only once and its output stored
in a temp file, to make the installation quicker. Please review the
attached patch.

Thanks!
Thomas.

cvs diff: Diffing .
Index: pkg-install
===================================================================
RCS file: /home/ncvs/ports/x11/gnome2/pkg-install,v
retrieving revision 1.9
diff -u -r1.9 pkg-install
--- pkg-install	5 Apr 2004 03:11:31 -0000	1.9
+++ pkg-install	26 Apr 2004 09:17:14 -0000
@@ -3,10 +3,15 @@
 PATH=/bin:/usr/bin:/sbin:/usr/sbin:${PATH}
 export PATH
 
+tmp_pkg_info=`mktemp -t gnome_install_pkg_info`
+trap "rm -f ${tmp_pkg_info}" 0
+
+pkg_info > ${tmp_pkg_info}
+
 if [ "$2" = "PRE-INSTALL" ]; then
      GNOME_ONE_DESKTOP="gnomecore gnomeapplets gnomemedia gnomeutils gtop libgtop sawfish nautilus gedit xalf bugbuddy gnomegames gdm eog ggv gnomeaudio"
      for package in ${GNOME_ONE_DESKTOP}; do
-	 if pkg_info | grep "^${package}-[0-9]" >/dev/null 2>&1; then
+	 if grep "^${package}-[0-9]" ${tmp_pkg_info} >/dev/null 2>&1; then
 	     echo "${package} was detected on the system.  This package is part of the GNOME 1.x"
 	     echo "desktop, and cannot coexist with the GNOME 2.2 desktop."
 	     echo ""

-- 
    Thomas.Quinot at Cuivre.FR.EU.ORG