graphics/sodipodi (0.32) build has been failed..

[Jeremy Messenger]

On 21 Jun 2003 01:57:56 +0200, Franz Klammer <klammer at webonaut.com> wrote:

> On Fri, 2003-06-20 at 21:26, Jeremy Messenger wrote:
>> Kill the M2 client's mime type.. Sorry for spam..
>>
>
> you are not the only one who had this problem in the
> last time. i'm also :-)

Hehe, Opera M2 is pretty b!tch with any of attach with end of c.. I already 
edited the mime types and don't change anything, but the diff and patch 
works perfect and obey my change. I have submitted over at Opera's forum 
for help.

>> ------patch-src::helper::action.c------
>> --- src/helper/action.c.orig	Fri Jun 20 15:59:10 2003
>> +++ src/helper/action.c	Fri Jun 20 16:05:30 2003
>> @@ -12,7 +12,9 @@
>> */
>> #include <string.h>
>> +#ifdef HAVE_MALLOC_H
>> #include <malloc.h>
>> +#endif
>> #include <libnr/nr-macros.h>
>> ------patch-src::helper::action.c------
>>
>
> i have a limited knowledge in C

Well, I know nothing, but a hello world. ;-)

> but i'm not sure that this
> ist the right way. wouldn't it be better that you change
> the #inlcude <malloc.h> to #include <stdlib.h>?
> i think there must be a reason why this file is included even if the port 
> build with out malloc.h.
>
> many other ports do it in this way. here an example from
> mozilla/Makefile:
>
> @${FIND} ${WRKSRC}/other-licenses/libical -name "*.c" | ${XARGS} \
> ${REINPLACE_CMD} 's|<malloc.h>|<stdlib.h>|g'

sodipodi works fine with me so far that I have tested. I learned it from 
graphics/sodipodi/files/patch-src::xml::repr-io.c .. Anyway, I did the test 
on both way and they both work fine, so I might be blind to not see any 
difference. :-)

Cheers,
Mezz

> franz.

<snip>


-- 
bsdforums.org 's moderator, mezz.