svn primer translation to git
Mateusz Piotrowski
0mp at FreeBSD.org
Thu Jun 25 09:13:34 UTC 2020
On 6/25/20 9:09 AM, Kristof Provost wrote:
> On 25 Jun 2020, at 8:24, Emanuel Haupt wrote:
>> Ed Maste <emaste at freebsd.org> wrote:
>>> We currently have a FreeBSD Subversion primer in the committer's
>>> guide:
>>> https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/subversion-primer.html
>>>
>>>
>>> I've started a translation of this into a Git primer, at:
>>> https://hackmd.io/ML5TSl8mQ5-27B5eqDf7YA?view
>>>
>>> I'm particularly interested in feedback on how much git background /
>>> theory of operation we want to include here (vs referring to external
>>> documentation).
>>
[...]
>
> I’ve had a look at the last few commits, and only the MFCs stand out as
> needing a little attention in that area.
> To grab a random example:
>
> MFC r362183
>
> netmap: vtnet: fix races in vtnet_netmap_reg()
>
> The nm_register callback needs to call nm_set_native_flags()
> or nm_clear_native_flags() once the device has been stopped.
[...]
>
> The original commit already followed the ‘headline summary, expanded
> body’ rule. This MFC would also work (often there’s no blank line
> between the ‘MFC’ and the next line), but I do wonder if `MFC r362183:
> netmap: vtnet: fix races in vtnet_netmap_reg()` wouldn’t be better.
+1.
And then if you're MFC'ing multiple commits at once, you'd just add a
little title capturing the change as a whole?
More information about the freebsd-git
mailing list