pull requests

Warner Losh imp at bsdimp.com
Wed Mar 1 16:14:25 UTC 2017


On Wed, Mar 1, 2017 at 9:08 AM, Kristof Provost <kp at freebsd.org> wrote:
> On 1 Mar 2017, at 15:48, Warner Losh wrote:
>>
>> Anyway, I got bored waiting for people to answer, so I did this
>>
>> https://wiki.freebsd.org/GithubPullRequests
>>
>> Which basically says if it is committable, we'll channel it in,
>> otherwise we won't. And we'll close after a month by pushing it off to
>> bugzilla.
>>
>> I'd like useful feedback on that.
>>
>
>> Pull requests older than 18 months will be converted to bugzilla items to
>> not lose them.
>
>
> I’m not sure I understand what you’re getting at here. Presumably it doesn’t
> mean that pull requests without activity will sit around for 18 months
> before
> they’re archived in bugzilla.  Is this about pull requests that have been
> closed? Is there any reason to migrate those?

The idea is that after a while pull requests are too stale. Now that I
think about it, maybe 18 months is far too long and I should say
something smaller, or have some other criteria more directly related
to it being actually stale.

But there's no value to keeping pull requests open just in case. That
degrades the value of having this as a service for simple, ready to go
things. If it gets too old, it no longer fits that definition.

Warner


More information about the freebsd-git mailing list