pull requests

Warner Losh imp at bsdimp.com
Wed Mar 1 14:48:03 UTC 2017


On Wed, Mar 1, 2017 at 2:36 AM, Bartłomiej Rutkowski <robak at freebsd.org> wrote:
>
>
> On Wed, Mar 1, 2017 at 12:16 AM, Warner Losh <imp at bsdimp.com> wrote:
>>
>> So, policy on github pull requests.
>>
>> Do we have one?
>>
>> If not, I'm going to set a sensible one and publish. Or set one and
>> get you folks to review. I'd like to see us down to 0 open pull
>> requests by the end of March.
>>
>> Warner
>
>
> What kind of policy, regarding what and 'policing' what and how exactly? Who
> and how will enforce such policy and on whom? In the end, "we can't force
> anyone to do anything" so unless we commit to do something on GitHub, I'd
> see it as a dead law.

This answer wins my "Least helpful answer of the year award." Insert rant here.

> Not to mention I've got a feeling this is completely disconnected from the
> general direction that I think has been 'agreed', that is we'll have a
> software solution getting GH PR's into Phabric reviews and GH Issues into
> Bugzilla PR's automatically. What then, shouldn't it be more like Phabric
> reviews/Bugzilla PR policy instead?

It certainly doesn't. It documents what we do with them today.

Anyway, I got bored waiting for people to answer, so I did this

https://wiki.freebsd.org/GithubPullRequests

Which basically says if it is committable, we'll channel it in,
otherwise we won't. And we'll close after a month by pushing it off to
bugzilla.

I'd like useful feedback on that.

And if things change, we change the above. It's not like we have to
guarantee anything. We just  have to document what people can expect.
If others make it more automated or better than my efforts, great. We
document that when it comes along.

Warner


More information about the freebsd-git mailing list