pull requests

[Kristof Provost]

On 1 Mar 2017, at 10:36, Bartłomiej Rutkowski wrote:
> What kind of policy, regarding what and 'policing' what and how 
> exactly?
> Who and how will enforce such policy and on whom? In the end, "we 
> can't
> force anyone to do anything" so unless we commit to do something on 
> GitHub,
> I'd see it as a dead law.
>
There is an official FreeBSD account on GitHub and I don’t expect that 
to go
away.

See
https://github.com/freebsd/freebsd/pulls

(As an aside, I note that someone has been cleaning these up. Awesome.)

We are getting pull requests there and something should be done with 
them.

> Not to mention I've got a feeling this is completely disconnected from 
> the
> general direction that I think has been 'agreed', that is we'll have a
> software solution getting GH PR's into Phabric reviews and GH Issues 
> into
> Bugzilla PR's automatically. What then, shouldn't it be more like 
> Phabric
> reviews/Bugzilla PR policy instead?
>
This is probably a good answer to the question of what to do with those 
pull
requests.

As the current situation is “they’re completely ignored” anything 
would be an
improvement. Even automatically closing them with “Go to <foo> 
instead.” would
be an improvement.

It might be nice to document a review policy (usable for GitHub, 
Phabricator,
e-mail reviews, …) somewhere. Things like “How long do I wait for 
reviews?”,
“Who do I subscribe/cc/…?”, “What should be done with abandoned 
reviews?” …

I fully support Warner’s efforts.

Regards,
Krsitof