geli panics my system after suspend-resume: g_eli_orphan_spoil_assert() called for cd0.eli

[Pawel Jakub Dawidek]

On Thu, Jul 02, 2015 at 12:53:12AM +0200, José García Juanino wrote:
> On 1 July 2015 at 21:30, Matthew D. Fuller <fullermd at over-yonder.net> wrote:
> > On Wed, Jul 01, 2015 at 05:42:33PM +0200 I heard the voice of
> > Pawel Jakub Dawidek, and lo! it spake thus:
> >>
> >> The spoil event happens when provider is open for writting for the
> >> first time (its open-for-write counter goes from 0 to >0). Since
> >> GELI opens its providers always exclusively there can be no write
> >> opens, thus the spoil event is unexpected.
> >
> > Well, from OP
> > (https://lists.freebsd.org/pipermail/freebsd-current/2015-June/056193.html)
> > it's coming from a CD media change event.  The BT linked from the mail
> > shows.
> >
> > panic() at panic+0x43/frame 0xfffffe011ba81b00
> > g_eli_orphan_spoil_assert() at g_eli_orphan_spoil_assert+0x1f/frame 0xfffffe011ba81b10
> > g_spoil_event() at g_spoil_event+0x72/frame 0xfffffe011ba81b40
> > g_media_changed_event() at g_media_changed_event+0x68/frame 0xfffffe011ba81b70
> > g_run_events() at g_run_events+0x1a7/frame 0xfffffe011ba81bb0
> >
> >
> >> To see what exactly is happening I'd need to see the console output
> >> from before that happens with kern.geom.debugflags set to 5.
> >
> > 'd have to talk to José for that; added him back to CC.
> 
> Hi, thanks for your support!
> 
> You can see the console output here, after setting
> kern.geom.debugflags=5 in /boot/loader.conf:
> 
> http://picpaste.com/panic_geli.jpg
> 
> Previously, I ran:
> 
> # geli attach -r /dev/cd0
> # mount /dev/cd0.eli /cdrom
> 
> ### close the laptop lid and waits a few seconds. The system suspends.
> ### open the laptop again. The system resumes. Wait a few seconds: the
> system panics.

THank you for the screenshot. My assumptions are out-dated. With
g_media_changed() we can get spoil event even if we hold provider
exclusively open. Your patch, Matthew, is correct, but could you also
update the comment there to take into account g_media_changed()
addition?

Thanks.

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
FreeBSD committer                         http://www.FreeBSD.org
Am I Evil? Yes, I Am!                     http://mobter.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.freebsd.org/pipermail/freebsd-geom/attachments/20150702/a1030c4b/attachment.bin>