kern/175323: Fail to use ZVOL as a gmirror component
Andriy Gapon
avg at FreeBSD.org
Sat Jan 26 10:51:45 UTC 2013
on 22/01/2013 19:48 Alexander Motin said the following:
> That looks fine to me. I would just do it as:
Committed. Thanks to everyone!
> --- g_mirror.c (revision 245794)
> +++ g_mirror.c (working copy)
> @@ -457,9 +457,7 @@ g_mirror_init_disk(struct g_mirror_softc *sc, stru
> disk->d_priority = md->md_priority;
> disk->d_flags = md->md_dflags;
> error = g_getattr("GEOM::candelete", disk->d_consumer, &i);
> - if (error != 0)
> - goto fail;
> - if (i)
> + if (error == 0 && i != 0)
> disk->d_flags |= G_MIRROR_DISK_FLAG_CANDELETE;
> if (md->md_provider[0] != '\0')
> disk->d_flags |= G_MIRROR_DISK_FLAG_HARDCODED;
>
>
--
Andriy Gapon
More information about the freebsd-geom
mailing list