Escape unsafe characters for kern.geom.confxml XML dump

[Pawel Jakub Dawidek]

On Sat, Mar 13, 2010 at 10:35:52AM +0200, Jaakko Heinonen wrote:
> 
> Hi,
> 
> I intend to commit following patch unless there are objections. I have
> seen the problem commonly reported by FreeBSD users.
> 
> ---
> 
> Escape characters unsafe for XML output in GEOM class, instance and provider
> names.
> 
> - Characters in range 0x01-0x1f except '\t', '\n', and '\r' are replaced
>   with '?'. Those characters are disallowed in XML.
> - '&', '<', '>', '\'', '"' and characters in range 0x7f-0xff are replaced
>   with XML numeric character reference.
> 
> If the kern.geom.confxml sysctl provides invalid XML, libgeom
> geom_xml2tree() fails and utilities using it do not work. Unsafe
> characters are common in msdosfs and cd9660 labels.
> 
> PR:		kern/104389
> Submitter by:	Doug Steinwand (original version)

Patch looks good and it was something missing for a very long time.
Thanks for taking care of this.

-- 
Pawel Jakub Dawidek                       http://www.wheelsystems.com
pjd at FreeBSD.org                           http://www.FreeBSD.org
FreeBSD committer                         Am I Evil? Yes, I Am!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
Url : http://lists.freebsd.org/pipermail/freebsd-geom/attachments/20100315/fef4e971/attachment.pgp