Panic while loading GEOM BSD class (KASSERTions)

[Poul-Henning Kamp]

In message <20050405140735.GA75518 at freebsd.czest.pl>, "Wojciech A. Koszek" writ
es:
>On Tue, Apr 05, 2005 at 03:32:17PM +0200, Pawel Jakub Dawidek wrote:
>> On Mon, Apr 04, 2005 at 07:58:20PM +0000, Wojciech A. Koszek wrote:
>> +> Hello GEOM hackers,
>[..]
>> 
>> GEOM_BSD is always added to the kernel:
>> 
>> /sys/conf/files.alpha:geom/geom_bsd.c                   standard
>[..]
>> And if you want to ask if we should panic or not if class is already
>> there... I suggested phk@ in the past to just return an error, not
>> sure what his response was (maybe 'prepare a patch' :)).
>
>Hi Pawel,
>I mean exacly this. We have GEOM_BSD by default. but it would be nice to
>cleanly return with error code. Similar problem is reported with if_run.ko
>and if_ppp.ko (PR: kern/79493).

In current we have changed it to return EEXISTS if you try to load
a class with the same name as an already existing class.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk at FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.