Mounting root...

[George Hartzell]

Paul Mather writes:
 > [...]
 > This leaves the start_cmd the same, rather than using the swap1_start
 > function, because swap1_start checks a "no_swap" setting that doesn't
 > seem to be present on FreeBSD but is on NetBSD.  (I don't know if a
 > missing setting defaults to "NO," making this moot.)  Changing stop_cmd
 > to use the swap1_stop function makes turning off swap conditional on the
 > "swapoff" setting, instead of unconditional, in the case of setting
 > "stop_cmd='swapoff -a'".  So, I think the above patch preserves the
 > current behaviour, unless you set 'swapoff="YES"' in /etc/rc.conf, in
 > which case all swap partitions will be unmounted during shutdown.

I'm currently doing a buildworld w/ Pawel's patch, which
unconditionally unmounts swap on shutdown and also adds some
functionality to /etc/rc.d/addswap so that it also unmounts swap on
shutdown.

I am not in the flow of things enough to voice an opinion about
whether it's "better" to preserve the existing behaviour or be
straightforward.  I suppose it might depend on whether this change is
going to try to get into 5.3 or not....

With Paul's patch, you should also add a default value for swapoff in
/etc/defaults/rc.conf, or one of the functions in /etc/rc.subr will
whine about improper usage of the variable for all of the folks that
aren't using it.

g.