maintainer-feedback requested: [Bug 240686] security/nss: regressions tests require bash

[bugzilla-noreply at freebsd.org]

Bugzilla Automation <bugzilla at FreeBSD.org> has asked freebsd-gecko mailing list
<gecko at FreeBSD.org> for maintainer-feedback:
Bug 240686: security/nss: regressions tests require bash
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240686



--- Description ---
Running security/nss's regression tests reveals a number of shell errors from
test scripts that use bash features like the built-in UID variable and more
importantly arrays:

[: -ne: unexpected operator
./ssl.sh: 1245: Syntax error: word unexpected (expecting ")")
./ectest.sh: 49: Syntax error: word unexpected (expecting ")")

Running the tests with bash instead shows stunningly different results.
Before (sh):

Passed: 	    3017
Failed: 	    0
Failed with core:   0
ASan failures:	    0
Unknown status:     0

After (bash):

Passed: 	    14469
Failed: 	    0
Failed with core:   0
ASan failures:	    0
Unknown status:     48
TinderboxPrint:Unknown: 48

Patch attached. We could change the shebangs of all scripts to
/usr/local/bin/bash, but there is no need for this; simply calling the
top-level script with bash is enough.