[Bug 236567] lang/spidermonkey170, lang/spidermonkey38: clang 8 crashes during build on armv7 and armv6

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Mon Sep 9 17:59:02 UTC 2019


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236567

--- Comment #5 from commit-hook at freebsd.org ---
A commit references this bug:

Author: dim
Date: Mon Sep  9 17:58:27 UTC 2019
New revision: 352089
URL: https://svnweb.freebsd.org/changeset/base/352089

Log:
  MFC r351938:

  Pull in r371111 from upstream llvm trunk (by Eli Friedman):

    [IfConversion] Fix diamond conversion with unanalyzable branches.

    The code was incorrectly counting the number of identical
    instructions, and therefore tried to predicate an instruction which
    should not have been predicated.  This could have various effects: a
    compiler crash, an assembler failure, a miscompile, or just
    generating an extra, unnecessary instruction.

    Instead of depending on TargetInstrInfo::removeBranch, which only
    works on analyzable branches, just remove all branch instructions.

    Fixes https://bugs.llvm.org/show_bug.cgi?id=43121 and
    https://bugs.llvm.org/show_bug.cgi?id=41121 .

    Differential Revision: https://reviews.llvm.org/D67203

  This should fix "Unable to predicate BX killed renamable $r0" errors
  when building the lang/spidermonkey170 and lang/spidermonkey38 ports for
  armv7 and armv6.

  PR:           236567

Changes:
_U  stable/11/
  stable/11/contrib/llvm/lib/CodeGen/IfConversion.cpp
_U  stable/12/
  stable/12/contrib/llvm/lib/CodeGen/IfConversion.cpp

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the freebsd-gecko mailing list