New firefox not building

[Mikhail T.]

Hi!

Trying the port on a just-updated 11-stable/amd64 clang7 I get:

    /opt/bin/clang++70 -o nsImageModule.o -c
    -I/symbion/ports/www/firefox/work/.build/dist/stl_wrappers
    -I/symbion/ports/www/firefox/work/.build/dist/system_wrappers
    -include
    /symbion/ports/www/firefox/work/firefox-65.0/config/gcc_hidden.h
    -DNDEBUG=1 -DTRIMMED=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE
    -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL
    -I/symbion/ports/www/firefox/work/firefox-65.0/image/build
    -I/symbion/ports/www/firefox/work/.build/image/build
    -I/symbion/ports/www/firefox/work/firefox-65.0/image
    -I/symbion/ports/www/firefox/work/firefox-65.0/image/encoders/bmp
    -I/symbion/ports/www/firefox/work/firefox-65.0/image/encoders/ico
    -I/symbion/ports/www/firefox/work/firefox-65.0/image/encoders/jpeg
    -I/symbion/ports/www/firefox/work/firefox-65.0/image/encoders/png
    -I/symbion/ports/www/firefox/work/.build/dist/include
    -I/opt/include/nspr -I/opt/include/nss -I/opt/include/nss/nss
    -I/symbion/ports/www/firefox/work/.build/dist/include/nss
    -I/opt/include -I/opt/include -I/opt/include/pixman-1 -fPIC
    -DMOZILLA_CLIENT -include
    /symbion/ports/www/firefox/work/.build/mozilla-config.h
    -Qunused-arguments -DLIBICONV_PLUG -isystem /opt/include
    -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong
    -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body
    -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith
    -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits
    -Wunreachable-code -Wunreachable-code-return -Wwrite-strings
    -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion
    -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat
    -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wstring-conversion
    -Wtautological-overlap-compare
    -Wtautological-unsigned-enum-zero-compare
    -Wtautological-unsigned-zero-compare -Wno-inline-new-delete
    -Wno-error=deprecated-declarations -Wno-error=array-bounds
    -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat
    -Wformat-security -Wno-gnu-zero-variadic-macro-arguments
    -Wno-unknown-warning-option -Wno-return-type-c-linkage
    -fno-sized-deallocation -O2 -pipe -march=ivybridge -O3
    -DLIBICONV_PLUG -fstack-protector -isystem /opt/include
    -fno-strict-aliasing -DLIBICONV_PLUG -isystem /opt/include
    -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong
    -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections
    -fdata-sections -fno-exceptions -fno-math-errno -pipe -I/opt/include
    -O2 -O3 -fomit-frame-pointer -funwind-tables  -MD -MP -MF
    .deps/nsImageModule.o.pp
    /symbion/ports/www/firefox/work/firefox-65.0/image/build/nsImageModule.cpp
    In file included from
    /symbion/ports/www/firefox/work/.build/gfx/webrender_bindings/Unified_cpp_webrender_bindings0.cpp:20:
    /symbion/ports/www/firefox/work/firefox-65.0/gfx/webrender_bindings/RenderCompositor.cpp:35:47:
    error: use of
           undeclared identifier 'RenderCompositorEGL'; did you mean
    'RenderCompositorOGL'?
       UniquePtr<RenderCompositor> eglCompositor =
    RenderCompositorEGL::Create(aWidget);
    ^~~~~~~~~~~~~~~~~~~
    RenderCompositorOGL
    /symbion/ports/www/firefox/work/.build/dist/include/mozilla/webrender/RenderCompositorOGL.h:16:7:
    note:
           'RenderCompositorOGL' declared here
    class RenderCompositorOGL : public RenderCompositor {
           ^
    In file included from
    /symbion/ports/www/firefox/work/.build/gfx/webrender_bindings/Unified_cpp_webrender_bindings0.cpp:20:
    /symbion/ports/www/firefox/work/firefox-65.0/gfx/webrender_bindings/RenderCompositor.cpp:35:75:
    error: rvalue
           reference to type 'RefPtr<...>' cannot bind to lvalue of type
    'RefPtr<...>'
       UniquePtr<RenderCompositor> eglCompositor =
    RenderCompositorEGL::Create(aWidget);
    ^~~~~~~
    /symbion/ports/www/firefox/work/.build/dist/include/mozilla/webrender/RenderCompositorOGL.h:19:42:
    note: passing
           argument to parameter 'aWidget' here
           RefPtr<widget::CompositorWidget>&& aWidget);

The options are configured thus:

    _OPTIONS_READ=firefox-56.0_1,1
    _FILE_COMPLETE_OPTIONS_LIST=BUNDLED_CAIRO CANBERRA DBUS DEBUG DTRACE
    FFMPEG GCONF INTEGER_SAMPLES LIBPROXY OPTIMIZED_CFLAGS PGO PROFILE
    TEST ALSA JACK PULSEAUDIO SNDIO
    OPTIONS_FILE_UNSET+=BUNDLED_CAIRO
    OPTIONS_FILE_UNSET+=CANBERRA
    OPTIONS_FILE_SET+=DBUS
    OPTIONS_FILE_UNSET+=DEBUG
    OPTIONS_FILE_UNSET+=DTRACE
    OPTIONS_FILE_SET+=FFMPEG
    OPTIONS_FILE_UNSET+=GCONF
    OPTIONS_FILE_UNSET+=INTEGER_SAMPLES
    OPTIONS_FILE_UNSET+=LIBPROXY
    OPTIONS_FILE_SET+=OPTIMIZED_CFLAGS
    OPTIONS_FILE_UNSET+=PGO
    OPTIONS_FILE_UNSET+=PROFILE
    OPTIONS_FILE_UNSET+=TEST
    OPTIONS_FILE_SET+=ALSA
    OPTIONS_FILE_UNSET+=JACK
    OPTIONS_FILE_UNSET+=PULSEAUDIO
    OPTIONS_FILE_UNSET+=SNDIO

Should I file a PR, or is this a known issue? Thank you! Yours,

    -mi