[Bug 229064] Warnings from Mk/Uses/gecko.mk when creating INDEX

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229064

Rainer Hurling <rhurlin at gwdg.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rhurlin at gwdg.de

--- Comment #1 from Rainer Hurling <rhurlin at gwdg.de> ---
There is a new behaviour of www/firefox, introduced since
version 60.x, see [1][2]. Running Firefox as root is not supported any more.

So, gecko.mk fails, when it tries to run 'firefox --version'. If you use the
same command as a regular (non root) user, it does not fail.

I think we have to find another way to do the version check in
/usr/ports/Mk/Uses/gecko.mk:48 as root. For me, the following patch helps as a
workaround:

--- gecko.mk.orig       2018-05-01 08:57:58.482882000 +0200
+++ gecko.mk    2018-05-23 20:20:53.518158000 +0200
@@ -45,7 +45,7 @@
 60_DEPENDS=            ${LOCALBASE}/lib/firefox/firefox:www/firefox

 .if exists(${LOCALBASE}/bin/firefox)
-_GECKO_INSTALLED_VER!= ${LOCALBASE}/bin/firefox --version 2>/dev/null
+_GECKO_INSTALLED_VER!= su -m www -c '${LOCALBASE}/bin/firefox --version'
2>/dev/null
 _GECKO_INSTALLED_VER:=
${_GECKO_INSTALLED_VER:M[0-9][0-9]*:C/([0-9][0-9]).*/\1/g}
 .endif

Of course, that's not optimal and I am not sure, if it brings in new security
issues(?).



[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1323302
[2] https://hg.mozilla.org/integration/autoland/rev/90a06cdcb48f

-- 
You are receiving this mail because:
You are the assignee for the bug.