Firefox 56 in FreeBSD: Safe Browsing API key required

[Jan Beich]

Francois Marier <francois at mozilla.com> writes:

> On 07/08/17 09:37 PM, Jan Beich wrote:
>
>>> If you are indeed already including a Google API key in your builds,
>>> then all you need to do is to add the Safe Browsing API to it, see
>>> https://bugzilla.mozilla.org/show_bug.cgi?id=1377987#c0.
>> 
>> Does SafeBrowsing require defining MOZILLA_OFFICIAL during build which
>> would also enable Telemetry pings?
>
> Are you defining MOZILLA_OFFICIAL in your builds?

No, for now. Other downstream maintainers do, see
https://bugzilla.mozilla.org/show_bug.cgi?id=1352981

>
>>> Afterwards, if you send me the project ID (not the API key), I can
>>> liaise with Google to make sure it has the right access and appropriate
>>> quota.
>> 
>> Our gecko@ team shares Google API key with chromium@ team. rene@ was the
>> one who originally obtained the key, so maybe he still has the project ID.
>
> I just verified your API key in a custom build of Firefox and it will
> work for basic Safe Browsing V4 support as long as you don't set
> MOZILLA_OFFICIAL.

Doesn't seem to work, at least on firefox-56.0b6.

listmanager: [trimmed-timestamp]: stateArray: ,,,,
listmanager: [trimmed-timestamp]: update request: {
  "tableList": "goog-phish-proto,goog-malware-proto,goog-unwanted-proto,goog-badbinurl-proto,goog-downloadwhite-proto",
  "tableNames": {
    "goog-phish-proto": true,
    "goog-malware-proto": true,
    "goog-unwanted-proto": true,
    "goog-badbinurl-proto": true,
    "goog-downloadwhite-proto": true
  },
  "requestPayload": "CgkKB0ZpcmVmb3gaCggFEAIiAiACKAEaCggBEAIiAiACKAEaCggDEAIiAiACKAEaCggHEAIiAiACKAEaCggJEAIiAiACKAE=",
  "isPostRequest": false
}

listmanager: [trimmed-timestamp]: makeUpdateRequestForEntry_: requestPayload CgkKB0ZpcmVmb3gaCggFEAIiAiACKAEaCggBEAIiAiACKAEaCggDEAIiAiACKAEaCggHEAIiAiACKAEaCggJEAIiAiACKAE= update: https://safebrowsing.googleapis.com/v4/threatListUpdates:fetch?$ct=application/x-protobuf&key=[trimmed-google-api-key]&$httpMethod=POST tablelist: goog-phish-proto,goog-malware-proto,goog-unwanted-proto,goog-badbinurl-proto,goog-downloadwhite-proto

listmanager: [trimmed-timestamp]: download error for goog-phish-proto,goog-malware-proto,goog-unwanted-proto,goog-badbinurl-proto,goog-downloadwhite-proto: 403