[Bug 215867] www/firefox-esr: volume control don't work with SNDIO option

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=215867

--- Comment #10 from Jan Beich (mail not working) <jbeich at FreeBSD.org> ---
Comment on attachment 178800
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=178800
firefox-esr.diff

Can you split into files/patch-bugNNN chunks for easy lookup on
bugzilla.mozilla.org for more details or, at least, in which release landed?
For example, files/patch-bug1153179 if you only intend to backport the specific
one.

> -sndio_get_min_latency(cubeb * ctx, cubeb_stream_params params, uint32_t * latency_ms)
> +sndio_get_min_latency(cubeb * ctx, cubeb_stream_params params, uint32_t * latency_frames)
>  {
>    // XXX Not yet implemented.
> -  *latency_ms = 40;
> +  *latency_frames = 2048;

libcubeb only changed how latency is calculated in Firefox 50[1]. Do you really
need it on 45.x ? If so adjust sio_par.appbufsz like upstream did. Maybe you
want sndio fix[2] from Firefox 48 instead.

[1] https://github.com/kinetiknz/cubeb/commit/025b515bfed3 (API)
    https://github.com/kinetiknz/cubeb/commit/098b9f21bf99 (sndio)
    https://github.com/kinetiknz/cubeb/commit/46584e72bd5d (alsa)
    https://github.com/kinetiknz/cubeb/commit/645f58ed0094 (pulse)
[2] https://github.com/kinetiknz/cubeb/commit/658d7eba38d4

-- 
You are receiving this mail because:
You are the assignee for the bug.