[Bug 212028] www/firefox: Add SNDIO option

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212028

Tobias Kortkamp <t at tobik.me> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #176619|0                           |1
        is obsolete|                            |

--- Comment #5 from Tobias Kortkamp <t at tobik.me> ---
Created attachment 178426
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=178426&action=edit
gecko.diff

(In reply to Jan Beich (mail not working) from comment #4)
Thanks for the review and happy new year!  Here is an updated diff.

> OPTIONS_EXCLUDE=SNDIO may be better unless it works with 2.46.

This isn't necessary anymore and it works with Seamonkey 2.46.

> > +	@${ECHO} "OS_LIBS += ['sndio']" >> \
> > +		${MOZ_SRC}/media/webrtc/signaling/test/common.build
> Why does this affect FreeBSD and not OpenBSD?

Building Firefox with both TEST and SNDIO enabled will fail otherwise:

> /usr/ports/www/firefox/work/firefox-50.1.0/obj-x86_64-unknown-freebsd11.0/media/webrtc/signaling/test/tmpoP6TrD.list:
> [...]
> /usr/bin/ld: undefined reference to symbol `sio_open' (try adding -lsndio)
> /usr/local/lib/libsndio.so.6.1: could not read symbols: Bad value
> c++: error: linker command failed with exit code 1 (use -v to see invocation)

I don't know why this doesn't affect OpenBSD.

While test building I noticed that building with TEST=on in
mail/thunderbird and www/firefox-esr seems to be broken.
I don't think this is related to this patch:
http://marc.info/?t=147486738500002&r=1&w=2

Test logs for all Gecko ports at https://pkg.tobik.me/logs/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.